CLK 6.18 Namespacing (continued)#1155
Open
bmastbergen wants to merge 3 commits intociq-6.18.yfrom
Open
Conversation
Adds 'Provides: kernel = version' to base package for compatibility with packages depending on generic kernel capability.
Add versioned Provides for kernel-headers, kernel-devel, and kernel-devel-<arch> so the namespaced CLK packages satisfy the same dependency capabilities as stock Rocky kernel packages. Remove Conflicts on kernel-headers and kernel-cross-headers since the namespaced packages now provide those capabilities directly.
8a22ccd to
965fd43
Compare
- Add set -e so the script exits on any command failure - Add -f (--fail) to curl so HTTP errors are caught - Verify the downloaded crate against the known SHA256 from crates.io before extracting
Collaborator
Author
|
Added the bundle_bindgen.sh enhancements brought up in the 6.12 PR. |
PlaidCat
approved these changes
May 4, 2026
Collaborator
PlaidCat
left a comment
There was a problem hiding this comment.
Thanks for adding the SHA check.
![]()
ajorgens-ciq
approved these changes
May 5, 2026
There was a problem hiding this comment.
This seems unrelated to namespacing, but I'm not here to impose my own PR standards on another team.
jdieter
requested changes
May 6, 2026
| Obsoletes: glibc-kernheaders < 3.0-46 | ||
| Provides: glibc-kernheaders = 3.0-46 | ||
| Provides: kernel-headers = %{specversion}-%{release} | ||
| Conflicts: kernel-headers |
There was a problem hiding this comment.
Aren't we still replacing the files provided by kernel-headers? If so, we should still conflict here.
| %package cross-headers | ||
| Summary: Header files for the Linux kernel for use by cross-glibc | ||
| Provides: kernel-cross-headers = %{specversion}-%{release} | ||
| Conflicts: kernel-cross-headers |
There was a problem hiding this comment.
Aren't we still replacing the files provided by kernel-cross-headers? If so, we should still conflict here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLK 6.18 has already been namespaced, but based on the current namespacing design needs a couple of additional tweaks. This brings it in line with the proposed CLK 6.12 namespacing PR here: #1065 as well as the Namespace Kernel Package Design document here: https://ciqinc.atlassian.net/wiki/spaces/ENG/pages/2327904257/Namespaced+Kernel+Package+Design