Add support for generating shared challenges with shared deployment templates #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atting in web service
…emplates (#6) This updates add shared deployment templates for both web and TCP `instanced_type` challenges.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for generating shared challenges with shared deployment templates, extending the existing instanced challenge template generation functionality. Shared challenges differ from instanced challenges in that they run a single deployment accessible by all users, rather than creating per-user instances.
Key changes:
- Added Kubernetes deployment templates for shared web and TCP challenges
- Updated the generator logic to support both shared and instanced challenge types
- Fixed container naming and port mapping in the instanced TCP template
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| template/shared-web-k8s.yml | New Kubernetes deployment template for shared web challenges with Deployment, Service, and Ingress resources using Helm templating |
| template/shared-tcp-k8s.yml | New Kubernetes deployment template for shared TCP challenges with Deployment, Service, and IngressRouteTCP resources |
| template/instanced-tcp-k8s.yml | Fixed container name from "web" to "tcp" and added missing targetPort field to Service definition |
| src/library/generator.py | Added shared_template_file() method and conditional logic to generate appropriate template based on challenge type (shared vs instanced) |
| src/commands/challenge_creator.py | Extended prompt logic to request instanced_type for both "instanced" and "shared" challenge types, with improved handling of provided arguments |
| README.md | Updated documentation to reflect new shared template files and removed outdated note about shared templates not being supported |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.