Skip to content

Conversation

@The0mikkel
Copy link
Member

Update ctfpilot.com/node to cluster.ctfpilot.com/node

@The0mikkel The0mikkel self-assigned this Dec 8, 2025
Copilot AI review requested due to automatic review settings December 8, 2025 20:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Kubernetes node selector key convention from ctfpilot.com/node to cluster.ctfpilot.com/node in template files. This change standardizes the node selector naming pattern to use a more specific cluster.ctfpilot.com domain prefix, likely to better organize cluster-level resources and avoid naming conflicts with other ctfpilot.com labels used for challenge metadata.

  • Updated node tolerations and affinity rules in two Kubernetes deployment templates
  • Changed the key in both tolerations and nodeAffinity.requiredDuringSchedulingIgnoredDuringExecution sections

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
template/instanced-web-k8s.yml Updated node selector key in tolerations (line 42) and affinity matchExpressions (line 50) for web-based challenge deployments
template/instanced-tcp-k8s.yml Updated node selector key in tolerations (line 42) and affinity matchExpressions (line 50) for TCP-based challenge deployments

The changes are consistent across both files, and no other template files in the repository use this node selector key. The update is straightforward and maintains the same values (scaler) and operators, only changing the key name to follow the new convention.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@The0mikkel The0mikkel merged commit 4a714ce into main Dec 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants