Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
csmock/csmock
Outdated
| if not os.path.isdir(repo_dir): | ||
| parser.error("not a directory: %s" % repo_dir) | ||
| if not os.path.isdir(os.path.join(repo_dir, "repodata")): | ||
| parser.error("repo directory missing repodata/: %s" % repo_dir) |
Check warning
Code scanning / vcs-diff-lint
main: Formatting a regular string which could be an f-string
|
This is an experimental feature that I'm opening now for early feedback. It can be tested locally with something like: This would raise follow up questions like: how to handle scanners that aren't in the buildroot? I thought perhaps early experimental support could be expecting users to set that up with regular Though this is linked to an internal jira, it's not a pressing part of any ongoing project, so not much urgency here. |
Using this requires setting up the lockfile and local repo earlier using regular mock, as described here: https://github.com/rpm-software-management/mock/blob/main/docs/feature-hermetic-builds.md This requires that the required scanners are either provided by the host or present in the buildroot. For instance `-t gcc` will work only if `gcc` is a build dependency. `-t cppcheck` will work if the `--use-host-cppcheck` param is used. PSSECAUT-1524
|
I tried the above steps with a Fedora package and
I would not worry about |
|
Actually, we also use |
Thanks! will test more and fix.
Agree, but there are some RPMs that don't pull in gcc. For those I was leaning toward something like: once buildroot setup, check if gcc is present, if not log error and warn that gcc analyzer wont' work, continue scanning as normal.
Sounds good to me
Yep, this the one that trapped me up the most. I don't have a great answer in mind right now. |
I think this should be a warning at most. The idea behind this is that one should be able to define a common |
2 participants
Using this requires setting up the lockfile and local repo earlier using regular mock, as described here:
https://github.com/rpm-software-management/mock/blob/main/docs/feature-hermetic-builds.md
This requires that the required scanners are either provided by the host or present in the buildroot. For instance
-t gccwill work only ifgccis a build dependency.-t cppcheckwill work if the--use-host-cppcheckparam is used.PSSECAUT-1524