Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This param copies in the statically linked version of csgrep installed on the host into the mock root, removing the build dependency on csgrep. Requires the `csgrep-static` package is installed on the host. This is both to support hermetic (re-)builds with csmock and to work towards using unchanged mock configs from the original build.
sfowl
force-pushed
the
use-static-csgrep
branch
from
ae7c422 to
cb04d50
Compare
|
I only just noticed this commit 6da2490 but it looks like it's still in a non-main branch. I think I would prefer to use the approach there, i.e. make this default behaviour, don't add a new param, but maybe I'm missing something.. not sure why this hasn't made it into a PR yet. |
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Looks good. One minor comment inline.
| def symlink_static_csgrep_hook(_, mock): | ||
| return mock.exec_chroot_cmd("ln -s /usr/libexec/csgrep-static /usr/bin/csgrep") |
There was a problem hiding this comment.
This should be ln -fs ... so that the hook is idempotent. Otherwise it would fail when csmock is used with --no-clean and --skip-init.
|
@sfowl Commit 6da2490 has not been merged because of csutils/csdiff#235 -- I was unable to build |
|
The change was proposed in #216 but it was closed unresolved because of the reason mentioned above. |
|
The |
|
Closed in favour of #216 |
2 participants
This param copies in the statically linked version of csgrep installed on the host into the mock root, removing the build dependency on csgrep. Requires the
csgrep-staticpackage is installed on the host.This is both to support hermetic (re-)builds with csmock and to work towards using unchanged mock configs from the original build.