Open
Conversation
akshayarora2009
requested changes
Nov 5, 2016
Contributor
akshayarora2009
left a comment
akshayarora2009
left a comment
There was a problem hiding this comment.
- Please make sure you commit all files in a single commit, and raise ONE pull-request for different files of related task.
- As of now, communication service should have one endpoint - a POST which can send an email. I do not see any such endpoint here.
| from flask import Flask,jsonify,request,make_response | ||
| import constants as constants | ||
| from exception import CSSException | ||
| app=Flask(__name__) |
Contributor
There was a problem hiding this comment.
Not enough spacing given between lines (as per PEP 8 guidelines). If you are using PyCharm, violations should be underlined automatically.
| from exception import CSSException | ||
| app=Flask(__name__) | ||
| @app.route(constants.API_PATH_PREFIX + constants.API_PATH_EMAIL,methods=['GET']) | ||
| def get_email_id(): |
Contributor
There was a problem hiding this comment.
Don't get the point of this function, why is this endpoint needed? GET email? Why?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.