replication: add specification of GetReplicationDestinationInfo#79
Merged
Conversation
Member
|
changes LGTM @nicknevin can you fix the CI error and move it to ready for review? |
Madhu-1
reviewed
Apr 30, 2026
Nikhil-Ladha
reviewed
May 6, 2026
Comment on lines
+442
to
+447
| // The source volume or volume group for which destination | ||
| // details are requested. | ||
| // This field is REQUIRED. | ||
| ReplicationSource replication_source = 1; | ||
| // Secrets required by the plugin to complete the request. | ||
| map<string, string> secrets = 2 [(csi.v1.csi_secret) = true]; |
Contributor
There was a problem hiding this comment.
Based on how other RPCs are defined, I think secrets should come first and then the replication_source
Contributor
Author
There was a problem hiding this comment.
Makes sense to me. @Madhu-1 what do you think?
Member
There was a problem hiding this comment.
@nicknevin sounds good, can you please fix the DOC error
Contributor
Author
There was a problem hiding this comment.
Thanks. I presume you meant DCO error? Fixed and combined the two commits into one.
Introduce a new RPC `GetReplicationDestinationInfo` with a corresponding capability `GET_REPLICATION_DESTINATION_INFO`. This RPC can be called to retrieve the current destination volume or volume group details, including per-volume ID mappings for dynamic groups. This is necessary to support storage providers which have different volume IDs and volume group IDs on the source and destination sides of a replication relationship. Signed-off-by: Nick Nevin <nnevin@redhat.com>
Nikhil-Ladha
approved these changes
May 14, 2026
Madhu-1
approved these changes
May 15, 2026
Member
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 2 minutes 54 seconds in the queue, including 2 minutes 26 seconds running CI. Required conditions to merge
|
Rakshith-R
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new RPC
GetReplicationDestinationInfowith a corresponding capabilityGET_REPLICATION_DESTINATION_INFO. This RPC can be called to retrieve the current destination volume or volume group details, including per-volume ID mappings for dynamic groups.This is necessary to support storage providers which have different volume IDs and volume group IDs on the source and destination sides of a replication relationship.
Note: This is taken verbatim from @Madhu-1 's design proposal .