Resolves #238 - adding a Reqnroll integration #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also write the MSBuild for code-sharing and update the READMEs.
I'd forgotten to exclude the bin and obj directories. Also, a place where I'd used the wrong compiler symbol.
These are presently a copy-paste of the SpecFlow ones. That should be fine. I also want to test Reqnroll across versions, as it has received a number of upgrades since v1.0.0. I'll add that in a future commit.
Namespace changes from v1.x to v2.x mean I can't support both without compiler symbols and thus building two Reqnroll packages. Reqnroll v1.x was very short-lived (3 months) so I'm comfortable electing not to support it.
The cause of this and the remediation is documented on this pull request for Reqnroll: reqnroll/Reqnroll#1004 In short: I mustn't attempt to resolve ScenarioContext from that extension point. Instead resolve ScenarioInfo, which is all I ever needed anyway. The improved logic works with both Reqnroll 2.0.0+ and the legacy SpecFlow.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an integration for Reqnroll 2.0.0+ to CSF.Screenplay.
I have chosen explicitly not to support Reqnroll 1.x, because of a troublesome namespace switch.