Preserve signal payload integer precision in workflow.SignalWorkflow#482
Draft
Copilot wants to merge 2 commits into
Draft
Preserve signal payload integer precision in workflow.SignalWorkflow#482Copilot wants to merge 2 commits into
workflow.SignalWorkflow#482Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix SignalWorkflow large integer truncation issue
Preserve signal payload integer precision in May 29, 2026
workflow.SignalWorkflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workflow.SignalWorkflowcould silently corrupt large integers (>2^53) because the system activity acceptedinterface{}, forcing JSON numbers throughfloat64during activity argument decoding. This changed payload values before they reached typed signal channels.Root cause addressed: remove lossy
interface{}hopinternal/signals.Activities.DeliverWorkflowSignalnow acceptsjson.RawMessageinstead ofinterface{}for the signal argument.Signal API path updated to preserve typed payload encoding
workflow.SignalWorkflow[T]now serializesargwith the workflow converter up front and passes the result asjson.RawMessageto the system signal activity.Regression coverage for high-magnitude integers
tester/tester_test.gothat sends a payload containinguint64(123456789012345678)and asserts exact round-trip equality afterSignalWorkflow.