Skip to content

Add Status to ResourceInfo#190

Open
kobergj wants to merge 1 commit into
cs3org:mainfrom
kobergj:AddResourceStatus
Open

Add Status to ResourceInfo#190
kobergj wants to merge 1 commit into
cs3org:mainfrom
kobergj:AddResourceStatus

Conversation

@kobergj
Copy link
Copy Markdown
Contributor

@kobergj kobergj commented Dec 8, 2022

Adds a Status field to the resource info of a resource. This field can be used to signal a meta status of the resource (like "processing", "readytouse", "blocked", ...). For backwards compatibility an empty status should be considered as "ok"

@micbar
Copy link
Copy Markdown
Member

micbar commented Dec 9, 2022

@labkode @vascoguita The Generator seems to be broken, can you investigate why?

@micbar
Copy link
Copy Markdown
Member

micbar commented Sep 27, 2023

@kobergj Can you rebase?

Signed-off-by: jkoberg <jkoberg@owncloud.com>
@glpatcern
Copy link
Copy Markdown
Member

glpatcern commented Jan 7, 2025

Rediscussed today with @kobergj : this is still valid, though to be "properly usable" it should be an enum with a given list (and extendable) list of values as opposed to an unspecified string.

The current implementation in Reva edge uses an opaque, therefore a code review should be done to identify the actual meaningful values and add them here.

@flash7777
Copy link
Copy Markdown

Hi @kobergj — we just opened #272 which also touches ResourceInfo field 20.

We are adding an immutable boolean (field 20) as a persistent attribute for freezing resources (DMS/Aktenplan use case). We see this as fundamentally different from a transient processing status:

Since both target field 20, we should coordinate. A few options:

  1. One of us moves to field 21
  2. We combine both into a single message with both concepts
  3. Status becomes an enum (as suggested in the review) and we add RESOURCE_STATUS_IMMUTABLE — though we believe immutable deserves its own field since it has dedicated RPCs (SetImmutable/UnsetImmutable) and different semantics

Happy to discuss and find the best path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants