Conversation
…nt's flat config will exclude the local vendor files. Recreated .eslintignore (removed markdown fences) and ensured it contains: ort/ node_modules/ coverage/
Summary of ChangesHello @cs-util, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the ONNX Runtime Web (ORT) library, version 1.18.0, into the project. This integration is crucial for enabling high-performance machine learning model execution directly within web browsers. The changes include adding the necessary ORT WASM runtime files, configuring development settings for model paths, and updating ESLint rules to accommodate the new library structure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the ONNX Runtime Web library as a vendored dependency. The changes include adding the library files, updating the ESLint configuration to ignore them, and setting up default paths in index.html for development. My main feedback is on the .eslintignore file, which contains duplicate entries that should be removed for cleanliness. The pull request title and description could also be more descriptive to better communicate the purpose of the changes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <script> | ||
| // Local ORT and Silero VAD defaults for development. | ||
| // These can be overridden by setting the same window properties before this page loads. | ||
| window.ORT_WASM_PATH = window.ORT_WASM_PATH || '/ort/'; | ||
| // If you host the silero model locally, place it at /models/silero_v5_16k.onnx | ||
| window.SILERO_VAD_MODEL = | ||
| window.SILERO_VAD_MODEL || '/models/silero_v5_16k.onnx'; |
There was a problem hiding this comment.
The new inline script sets window.SILERO_VAD_MODEL to '/models/silero_v5_16k.onnx' for every page load. DEFAULT_SILERO_MODEL_URL in src/stt/config.js now always resolves to this local path, but the repo does not include a /models/silero_v5_16k.onnx asset. As a result ensureSession() attempts to fetch a non‑existent file and the ONNX InferenceSession creation fails, disabling VAD out of the box. Previously the app worked because the default URL pointed to the hosted GitHub model. Consider keeping the remote default unless a local model is actually provided.
Useful? React with 👍 / 👎.
1 participant
No description provided.