Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Conversation

@kirtixs
Copy link

@kirtixs kirtixs commented Oct 15, 2018

This pr updates hashed method names.

The hashes have been downloaded from https://www.4byte.directory/ and can be used in combination with any license as per their tos. A new util script has been added that automatically downloads the hashes from the site and saves them in a specified location.

Hashes that were present in known_hashes.py and not in 4byte.directiory have been submitted. As a positive side effect duplicate or bad methods have been removed from the list.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


redshark1802 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joshwatson
Copy link
Contributor

Thanks for the contribution! We're actually in the middle of a refactor of ethersplay, and knownHashes is moving to a different module, but we'll probably add the new methods from this into that module!

@kirtixs
Copy link
Author

kirtixs commented Oct 15, 2018

Thanks for letting me know. In the meantime, could you accept this pr until refactoring has finished. It would probably help a few users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants