This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Support filepaths starting with multiple '../'#18
Open
Zarfsec wants to merge 1 commit intocrytic:zarfsec-multiple-dot-dot-slashesfrom
Open
Support filepaths starting with multiple '../'#18Zarfsec wants to merge 1 commit intocrytic:zarfsec-multiple-dot-dot-slashesfrom
Zarfsec wants to merge 1 commit intocrytic:zarfsec-multiple-dot-dot-slashesfrom
Conversation
|
|
webthethird
reviewed
Jul 26, 2023
Contributor
There was a problem hiding this comment.
Could we count the number of times ../ appears, and use that number times 3 where we have path[3:] etc? Would be cleaner and more robust, i.e., in case a path starts with ../../../../../.
Contributor
|
I believe the Pytest tests are failing because your fork does not have the Etherscan API keys and RPC urls in its repo secrets. If you can add your own keys/urls in your fork, then when the tests are re-run they should pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite 'dirty' way to fix imports starting with multiple '../'.