Enabled switching between tls and net package#6
Open
GammaSQ wants to merge 4 commits intocryptocoinjs:masterfrom
Open
Enabled switching between tls and net package#6GammaSQ wants to merge 4 commits intocryptocoinjs:masterfrom
GammaSQ wants to merge 4 commits intocryptocoinjs:masterfrom
Conversation
Author
|
I just found out that node version 11.3 introduced a TLSSocket-class. This means that my cleartextStream-check will fail! So please run tests with node.js < 0.11.3 ! |
Author
|
Host-object now has a .TLS boolean. The .socket attribute is always used to save the cleartextStream/TLSSocket (if useTLS == true). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple enhancement to allow the connection to be encrypted. Tests are passing.
Weather tls or net is used can be set with a boolean in the settings.js and test-settings.js file.
(I felt like having settings for the tests split from general settings. Both settings still have to carry the same useTLS-setting!)
There is not yet an automated test to run all tests once with tls and once with net enabled.
To implement a switch dependent on cryptocoinjs/coininfo, it can be required within the settings.js.