refactor: threadsafe callbacks#108
Merged
ahmad-kemsan merged 3 commits intomasterfrom Mar 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the callback mechanism to be thread-safe by replacing the Napi::AsyncWorker pattern with Napi::ThreadSafeFunction. The changes consolidate callback handling into a single CallbackWrapper class and add mutex protection for callback map operations.
Key Changes:
- Replaced
AsyncWorker-based callbacks withThreadSafeFunctionfor proper thread-safe callback invocation - Unified
CallbackWrapperandReleaseUpdateCallbackWrapperinto a single polymorphicCallbackWrapperclass - Added mutex protection for callback map modifications during registration
- Implemented proper cleanup of existing callbacks before replacing them
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/native/CallbackWrapper.h | Complete refactor from AsyncWorker to ThreadSafeFunction pattern with data structures for different callback types |
| src/native/main.cpp | Added mutex for callback map protection, updated callback registration functions with cleanup logic, modified callback invocation to use new Call() methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ahmad-kemsan
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




No description provided.