feat: add MigrateToSystemWideActivation #16
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a new MigrateToSystemWideActivation procedure to the LexActivator Pascal wrapper, allowing users to migrate existing license data from user-specific storage to system-wide storage.
Changes:
- Added
MigrateToSystemWideActivationfunction declaration with documentation - Implemented the function wrapper that calls the underlying DLL function
- Accidentally included a .DS_Store file that should not be in version control
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/LexActivator.pas | Added new MigrateToSystemWideActivation procedure with documentation and implementation |
| examples/.DS_Store | macOS system file accidentally added to repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
examples/LexActivator.pas
Outdated
| set it first using SetDataDirectory(). | ||
| PARAMETERS: | ||
| * oldPermissionFlag - permission flag used previously |
There was a problem hiding this comment.
The documentation comment refers to "oldPermissionFlag" in the PARAMETERS section, but the actual parameter is named "Flags". Update the parameter documentation to match the actual parameter name.
| * oldPermissionFlag - permission flag used previously | |
| * Flags - permission flag used previously |
There was a problem hiding this comment.
changing parameter name accordingly.
| begin | ||
| if not ELAError.CheckOKFail(Thin_MigrateToSystemWideActivation(LAFlagsToLongWord[Flags])) then | ||
| raise | ||
| ELAFailException.Create('Migration to syswide storage failed'); |
There was a problem hiding this comment.
The error message "Migration to syswide storage failed" is generic and doesn't provide helpful information about why the migration failed. Consider including the specific error code or more context about the failure reason to help users diagnose issues.
| begin | |
| if not ELAError.CheckOKFail(Thin_MigrateToSystemWideActivation(LAFlagsToLongWord[Flags])) then | |
| raise | |
| ELAFailException.Create('Migration to syswide storage failed'); | |
| var | |
| Status: TLAStatusCode; | |
| begin | |
| Status := Thin_MigrateToSystemWideActivation(LAFlagsToLongWord[Flags]); | |
| if not ELAError.CheckOKFail(Status) then | |
| raise | |
| ELAFailException.CreateFmt('Migration to syswide storage failed (status code: %d)', [Ord(Status)]); |
No description provided.