[WIP] Update secp256k1 to btc v0.6.0 #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuJiandong
reviewed
Dec 11, 2024
Comment on lines
-43
to
+39
| $(SECP256K1_SRC_20210801): | ||
| cd deps/secp256k1-20210801 && \ | ||
| ./autogen.sh && \ | ||
| CC=$(CC) LD=$(LD) ./configure --with-bignum=no --enable-ecmult-static-precomputation --enable-endomorphism --enable-module-recovery --host=$(TARGET) && \ | ||
| make src/ecmult_static_pre_context.h src/ecmult_static_context.h | ||
|
|
||
| gcc -I deps/secp256k1-20210801/src -o $@ $< |
Contributor
There was a problem hiding this comment.
Why are these line removed? New secp256k1 lib don't require config?
Contributor
Author
There was a problem hiding this comment.
precomputed_ecmult.c already exists in the repositorie and does not need to be regenerated.
Contributor
There was a problem hiding this comment.
it is too large, about 2.3M bytes. We need a smaller one.
Contributor
Author
There was a problem hiding this comment.
But the exported secp256k1_data_20210801 is still 1M (1048576).
The size still needs to be controlled at around 20k? (ckb-auth)
Contributor
There was a problem hiding this comment.
it's ok to have same size as before (1M).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade secp256k1 to use the official version.
Size: 121K -> 143K
Cycles 1.43M -> 1.40M (Take the average of multiple
test_btc_success)