Feat(csparc2star): Add support for multi volume groups in CS v4.5+#1
Feat(csparc2star): Add support for multi volume groups in CS v4.5+#1valentinp wants to merge 1 commit into
Conversation
Daniel DM draft:
|
mcleanm
left a comment
There was a problem hiding this comment.
This PR looks good to me. A couple notes:
csparc2starappears to only read alignment-type fields (2D or 3D) from the first cs file in the list, i.e., not from any of the passthroughs- with this edit, the output star file's model parameters are read from one of the following slots, in order of descending preference:
alignments3Dalignments3D_multialignments_class_Xoralignments_class3D_X(whichever is in the first cs file)
- Thus:
- For jobs that output both
alignments3Dandalignments3D_multi(right now: Regroup 3D and Align 3D),csparc2starwill write model parameters fromalignments3D. This is fine because these jobs keep this updated with the multi - For jobs that only output
alignments3D_multi, (e.g. hetero refine, multi-class ab-initio, 3D classification, etc.),csparc2starwill write model parameters fromalignments3D_multi.
- For jobs that output both
To test, you can run:
pyem/csparc2star.py J9_00006_particles.cs J9_passthrough_particles_all_classes.cs particles.starwhereJ9is a classification job. This should work with either v4.4 or v4.5 outputs.