Skip to content

feat: Add support for acceptSourceChanges in string-based MergeBranch API #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinayakkamatcodes wants to merge 1 commit into from
Closed

feat: Add support for acceptSourceChanges in string-based MergeBranch API #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crowdin_api/api_resources/branches/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ class MergeBranchRequest(TypedDict):
deleteAfterMerge: Optional[bool]
sourceBranchId: int
dryRun: Optional[bool]
acceptSourceChanges: bool
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptSourceChanges field should be typed as Optional[bool] to maintain consistency with other optional fields in the MergeBranchRequest class (deleteAfterMerge and dryRun). Unless this is a required field, making it optional would provide a more flexible API design.

Suggested change
acceptSourceChanges: bool
acceptSourceChanges: Optional[bool]

Copilot uses AI. Check for mistakes.
Copy link
Member

@andrii-bodnar andrii-bodnar Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayakkamatcodes please address the comment above so I can merge the PR

Loading