This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Alt + T shortcut to toggle theatermode#97
Open
FierySama wants to merge 4 commits intocrowbartools:masterfrom
Open
Alt + T shortcut to toggle theatermode#97FierySama wants to merge 4 commits intocrowbartools:masterfrom
FierySama wants to merge 4 commits intocrowbartools:masterfrom
Conversation
Alt t keycombo now toggles theatermode on and off! Escape still works too.
Contributor
Author
|
This works fine on Chrome, however on Firefox while it works it brings up this menu each time. Will keep this PR open if anyone likes the concept enough |
This fixes alt bringing up Firefox's alt menu. Works on both chrome and ff.
Contributor
Author
|
It's terrible. since there is no check to see whether you're typing in chat, Shift + T means if you capitalize things in sentences often, you'll be toggling theater mode and off. This is the biggest flaw in this PR! ahhh!!! |
Member
|
This is a great idea Fiery! I wonder if Shift + Alt + T or something to that effect would fit all browser types |
SReject
approved these changes
Feb 5, 2020
The |
SReject
suggested changes
Feb 5, 2020
* Works on FF, Works on Chrome! * Thank you Reject and Biggz :D * I don't know how to test for macOS so far.
SReject
previously approved these changes
Feb 6, 2020
Keyup works fantastic here, works on Chrome and FF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alt + T key combo now toggles theater mode on and off! Escape still works too separately to exit theatermode
Description of the Change
Repurposed the escape event listener code to create a key combination of Alt + T that toggles theatermode on and off!
Updated tooltip
Slowed down this toast by 1/4 of a second for slower readers, feel free to revert this
Benefits
Possible Drawbacks
I admit I have no idea how this will function on MacOs. I used this https://www.w3.org/TR/uievents-code/#keyboard-key-codes . I assume alt/option + T on mac may still do the same thing?
Credit
SReject helped me remove redundant code before this commit, thanks Reject!