This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Custom Emote modal picker to bottom for convenience#83
Open
FierySama wants to merge 3 commits intocrowbartools:devfrom
Open
Custom Emote modal picker to bottom for convenience#83FierySama wants to merge 3 commits intocrowbartools:devfrom
FierySama wants to merge 3 commits intocrowbartools:devfrom
Conversation
added 2 commits
November 9, 2019 20:42
Merge upstream dev to fork
Brings Mixer vs Elixr emotes closer to smiley button
This reverts commit 7527792.
Contributor
Author
|
Sorry about that, I didn't understand the pr was attached to the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Emote mode switcher modal to bottom for convenience so users don't have switch up top
Benefits
Closer access to the smiley, to avoid extra mouse movement
Possible Drawbacks
It's still a little inconvenient to switch, since emote access is still up top. Example: switching from elixr to sub emotes, you have to put your mouse up top anyway. Possible solution if emote switching is at the bottom through this PR, then emotes may have to change to generate most important at the bottom of the menu first to avoid all inconvenience related to emote mode switching.
Applicable Issues
See possible drawbacks, will take emote menu reorganizing to become fully convenient. This PR will instead serve as an idea for an optional feature, or if major change comes through it could default here.