Closed
Conversation
Signed-off-by: Daniel Oliveira <drawnpoetry@gmail.com>
VA is used twice instead of size property. Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Author
|
@DavidMCerdeira It seems to me that you have lost this commit bec5e40 in next branch while force-pushing next branch 50 mins ago. It was fixing this issue: crosscon/CROSSCON-Hypervisor-and-TEE-Isolation-Demos#22 I am no expert here, but it seems some parts of this commit is missing. Can you please clarify whether this fix is applied in other manner? BTW, I am not sure how good idea it is to force-push |
|
You are right. I was not careful enough. Here is the restored commit for the fix: d211573 |
Author
|
Thanks. I am also opening another MR in favor of this one with my fix in the log, if you can take a look: #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VA is used twice instead of size property.