Fix callback persistence chaining using Fanout pattern#509
Open
kieranklaassen wants to merge 2 commits intocrmne:mainfrom
Open
Fix callback persistence chaining using Fanout pattern#509kieranklaassen wants to merge 2 commits intocrmne:mainfrom
kieranklaassen wants to merge 2 commits intocrmne:mainfrom
Conversation
dce45e2 to
6e80976
Compare
19 tasks
When using acts_as_chat, persistence callbacks were being overwritten when users added their own callbacks via on_new_message, on_end_message, etc. This caused silent data loss. The fix adds a simple CallbackFanout class that appends callbacks instead of replacing them, so both persistence and user callbacks run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts: # lib/ruby_llm/chat.rb
1a6132e to
6303cdb
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
acts_as_chat, persistence callbacks were silently overwritten when users added their own callbacks:Solution
Add a simple
CallbackFanoutclass that appends callbacks instead of replacing them:Changes
CallbackFanoutclassNet result: -20 lines while fixing the bug.