-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix(memory): anchor LanceDB scope matching on path boundary #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Osamaali313
wants to merge
1
commit into
crewAIInc:main
Choose a base branch
from
Osamaali313:fix/lancedb-scope-boundary
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−11
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Unescaped LIKE wildcards (
_,%) can reintroduce the very sibling leakage this PR fixes.safeonly escapes single quotes. In theLIKEbranch,_(single-char wildcard) and%(multi-char wildcard) are still interpreted by the matcher. A scope containing an underscore — common in team/scope names — will match unrelated siblings:_scope_prefix_clause("/team_x")→scope LIKE '/team_x/%', which also matches/teamAx/child,/team1x/child, etc. (the_matches any single character).%behaves even more broadly.The exact-match branch is unaffected, but the descendant branch leaks across boundaries, defeating the fix. Escape LIKE metacharacters and add an
ESCAPEclause.🛡️ Proposed fix (escape LIKE metacharacters)
prefix = scope_prefix.rstrip("/") if not prefix.startswith("/"): prefix = "/" + prefix safe = prefix.replace("'", "''") - return f"(scope = '{safe}' OR scope LIKE '{safe}/%')" + # Escape LIKE metacharacters so scopes containing '_' or '%' do not + # match unrelated siblings (e.g. '/team_x' must not match '/teamAx/..'). + like_prefix = ( + safe.replace("\\", "\\\\").replace("%", "\\%").replace("_", "\\_") + ) + return f"(scope = '{safe}' OR scope LIKE '{like_prefix}/%' ESCAPE '\\')"Please confirm LanceDB 0.29.2 (DataFusion SQL) honors the
ESCAPEclause onLIKE; if not, the descendant match needs an alternative anchoring approach.🤖 Prompt for AI Agents