fix: replace raw echo with output helpers in git/make-preview#669
Merged
Merged
Conversation
Updated die() to the standard implementation (printf with red ✗ to stderr) and added info() and success() helpers. Replaced the bare echo with info "Using Branch: …" and added a success message on completion. Closes #645 Prompt: Work on issue #645 in credfeto/scripts. Replace raw echo with output helpers in git/make-preview.
Collaborator
|
All CI checks passed (build-pre-release ✓, pull-request ✓). No outstanding review comments. PR marked as ready for review. |
Owner
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Collaborator
|
All CI checks pass (build-pre-release ✓, lint-code ✓, BASH linting ✓, valid-changelog ✓, and all other required checks ✓). No review comments or change requests. PR is ready and awaiting human approval. |
credfeto
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
die()ingit/make-previewto the standard implementation (printf with red ✗ to stderr)info()andsuccess()output helpers following the project shell-script conventionsecho "Using Branch: $BRANCH"withinfo "Using Branch: $BRANCH"success "Branch $BRANCH created and pushed"on completionCloses #645
Test plan
shellcheck git/make-preview— no warningsDOTNET_PREVIEW_VERSIONunset triggers die with red ✗ on stderr and exits non-zero→ Using Branch: …and✓ Branch … created and pushed