Skip to content

fix: replace raw echo with output helpers in git/missing-release-branches#668

Merged
credfeto merged 1 commit into
mainfrom
fix/646-replace-echo-with-output-helpers-in-missing-release-branches
Jun 6, 2026
Merged

fix: replace raw echo with output helpers in git/missing-release-branches#668
credfeto merged 1 commit into
mainfrom
fix/646-replace-echo-with-output-helpers-in-missing-release-branches

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jun 6, 2026

Summary

  • Add die, info, and success output helpers to git/missing-release-branches
  • Replace all user-facing echo calls with the appropriate helper (info for progress/status, success for completion, die for fatal errors)
  • Preserve internal echo "Y" inside matchingBranch which is used as a return value via command substitution — not user-facing output
  • Fix A && B || C anti-pattern flagged by shellcheck (SC2015) by restructuring to a proper if/then/else
  • Drop misleading || echo "Switching to Main" fallback in favour of || true since the intent is to continue even if the switch fails

Closes #646

…ches

Replace bare echo calls with die/info/success helpers for consistent,
coloured output and proper error-exit behaviour on failure.

Prompt: Work on issue #646 in credfeto/scripts. Replace raw echo with output helpers (die, info, success) in git/missing-release-branches.

Closes #646
@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 6, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as draft June 6, 2026 09:23
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 6, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 6, 2026 09:29
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

All CI checks passing. No review comments to address. Marking PR as ready for review.

Summary of changes in this PR:

  • Added die, info, and success output helper functions to git/missing-release-branches
  • Replaced user-facing echo calls with the appropriate helper (info for progress, success for completion, die for fatal errors)
  • Retained internal echo "Y" in matchingBranch — it is a return value via command substitution, not user-facing output
  • Fixed shellcheck SC2015 (A && B || C anti-pattern) by restructuring to a proper if/then/else
  • Replaced || echo "Switching to Main" with || true to preserve the continue-on-failure intent without bare echo

@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 6, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

All CI checks passing and no outstanding review comments. PR is ready for merge.

CI summary:

  • BASH linting: pass
  • build-pre-release: pass
  • change-log-entry-is-in-unreleased: pass
  • does-not-contain-secrets: pass
  • has-no-merge-conflicts: pass
  • include-changelog-entry: pass
  • lint-code: pass
  • valid-changelog: pass
  • no-ignored-files: pass
  • no-merge-commits: pass
  • dependency-review: pass

@credfeto credfeto enabled auto-merge June 6, 2026 12:10
@credfeto credfeto merged commit 94ca14c into main Jun 6, 2026
46 checks passed
@credfeto credfeto deleted the fix/646-replace-echo-with-output-helpers-in-missing-release-branches branch June 6, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in git/missing-release-branches

2 participants