Skip to content

fix: replace raw echo with output helpers in git/mkmissing-release#667

Merged
credfeto merged 2 commits into
mainfrom
fix/647-mkmissing-release-echo-helpers
Jun 6, 2026
Merged

fix: replace raw echo with output helpers in git/mkmissing-release#667
credfeto merged 2 commits into
mainfrom
fix/647-mkmissing-release-echo-helpers

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jun 5, 2026

Summary

Replace all four bare echo calls in git/mkmissing-release with the standard output helpers (die, info, success) as required by the shell-script output helper conventions.

Changes

  • Added die, success, and info helper functions to git/mkmissing-release
  • Replaced echo "Script Dir: $BASEDIR" with info
  • Replaced echo "$line" (repo path) with info
  • Replaced echo "==== $CURRENT_DIR ===" (section header) with info
  • Replaced echo " * done" with success

All changes pass shellcheck and checkbashisms.

Closes #647

@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 changed the title chore: update changelog for fix/647-mkmissing-release-echo-helpers fix: replace raw echo with output helpers in git/mkmissing-release Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as draft June 5, 2026 23:19
@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 5, 2026 23:41
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

All CI checks passed and code review is clean. Marking as ready for review.

Review summary:

  • All four bare echo calls replaced with die/info/success helpers
  • Helper implementations match the reference in shell-scripts.examples.md
  • shellcheck and checkbashisms pass
  • CHANGELOG entry added under Fixed
  • All CI checks: pass

@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

PR is ready and all checks pass. No action required.

Status:

  • All CI checks: pass (build, lint, changelog, secrets, merge conflicts, no-ignored-files, dependency-review)
  • Copilot Code Review: pass
  • No pending review comments
  • Mergeable: yes

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

No outstanding work. PR remains ready for review with all CI checks passing and no pending comments or review requests.

@credfeto credfeto enabled auto-merge June 6, 2026 09:03
Replace all four bare echo calls with die/info/success helpers as defined
by the shell-script output helper conventions.

Prompt: Replace raw echo with output helpers in git/mkmissing-release (issue #647)

Closes #647
@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/647-mkmissing-release-echo-helpers branch from 0e92c8d to f144a1d Compare June 6, 2026 09:10
@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 6, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@credfeto credfeto merged commit ccae584 into main Jun 6, 2026
28 checks passed
@credfeto credfeto deleted the fix/647-mkmissing-release-echo-helpers branch June 6, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in git/mkmissing-release

2 participants