Skip to content

fix: replace raw echo with output helpers in git/optimise-git#665

Merged
credfeto merged 1 commit into
mainfrom
fix/648-optimise-git-echo-helpers
Jun 5, 2026
Merged

fix: replace raw echo with output helpers in git/optimise-git#665
credfeto merged 1 commit into
mainfrom
fix/648-optimise-git-echo-helpers

Conversation

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

Summary

  • Replace all user-facing raw echo calls in git/optimise-git with the standard output helpers (die, info, success)
  • Add the output helper function definitions at the top of the script
  • Fix shebang spacing (#! /bin/sh#!/bin/sh) for consistency
  • Preserve all existing script behaviour

Closes #648

Test plan

  • Run shellcheck git/optimise-git — should pass with no warnings
  • Verify the script executes correctly against a directory tree of git repos
  • Confirm all pre-commit checks pass (they passed in CI during commit)

Replace all user-facing raw echo calls with die/info/success helpers in git/optimise-git, consistent with the project's shell-script output conventions.

Closes #648

Prompt: Replace raw echo with output helpers in `git/optimise-git`
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 self-assigned this Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 5, 2026 21:18
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator Author

PR is ready for review.

All pre-commit checks (shellcheck, linters, changelog lint, TruffleHog) passed locally. CI checks build-pre-release and pull-request both passed. No review comments to address.

@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator Author

All CI checks have passed and there is no outstanding work.

CI summary:

  • build-pre-release — pass
  • lint-code (BASH super-linter) — pass
  • change-log-entry-is-in-unreleased — pass
  • valid-changelog — pass
  • include-changelog-entry — pass
  • does-not-contain-secrets — pass
  • has-no-merge-conflicts — pass
  • no-merge-commits — pass
  • has-no-file-or-folder-case-sensitivity-issues — pass
  • dependency-review — pass

No review comments to address. PR is ready for merge.

@credfeto credfeto enabled auto-merge June 5, 2026 22:03
@credfeto credfeto merged commit b2c10d5 into main Jun 5, 2026
49 checks passed
@credfeto credfeto deleted the fix/648-optimise-git-echo-helpers branch June 5, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in git/optimise-git

2 participants