Skip to content

fix: replace raw echo with standard output helpers in git/update-dotnet-sdk #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
credfeto merged 2 commits into from
Jun 5, 2026
Merged

fix: replace raw echo with standard output helpers in git/update-dotnet-sdk #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eadd601
fix: replace raw echo with standard output helpers in git/update-dotn…
dnyw4l3n13 Jun 5, 2026
285db6f
chore: add changelog entry for #650
dnyw4l3n13 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release
- Replace raw echo output with standard die/success/info helpers in network/wg-create
- Replace raw echo with output helpers in linux/install-fp
- Replace raw echo with output helpers in git/update-preview
- Replace raw echo with standard output helpers in git/update-dotnet-sdk
### Changed
- GEOIP - Updated GEOIP DB from MaxMind (2026-06-03)
- Replace raw echo with standard output helpers (die/info/success) in github/cancel-workflows
Expand Down
11 changes: 7 additions & 4 deletions git/update-dotnet-sdk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
#! /bin/sh

die() {
echo
echo "$@"
printf '\n\033[31m✗\033[0m %s\n' "$*" >&2
exit 1
}

info() {
printf '\n\033[32m→\033[0m %s\n' "$*"
}

BASEDIR="$(dirname "$(readlink -f "$0")")"

# shellcheck source=/dev/null
Expand All @@ -20,7 +23,7 @@ LATEST_GA_RELEASE=$(dotnet --list-sdks | cut -f 1 -d " " | grep "^$DOTNET_PREVIE
LATEST_PRE_RELEASE=$(dotnet --list-sdks | cut -f 1 -d " " | grep "^$DOTNET_PREVIEW_VERSION\.[0-9]*\.[0-9]*-" | sort | tail -1)

if [ -n "$LATEST_GA_RELEASE" ]; then
echo "Latest GA release: $LATEST_GA_RELEASE";
info "Latest GA release: $LATEST_GA_RELEASE"

TMP_JSON=$(mktemp)
cat "$GLOBAL_JSON" | \
Expand All @@ -36,7 +39,7 @@ if [ -n "$LATEST_GA_RELEASE" ]; then
git add "$GLOBAL_JSON" && git commit "$GLOBAL_JSON" -m"Updated DotNet SDK to $LATEST_GA_RELEASE" && git push

elif [ -n "$LATEST_PRE_RELEASE" ]; then
echo "Latest preview release: $LATEST_PRE_RELEASE"
info "Latest preview release: $LATEST_PRE_RELEASE"

TMP_JSON=$(mktemp)
cat "$GLOBAL_JSON" | \
Expand Down
Loading