Skip to content

fix: replace raw echo with standard output helpers in github/cancel-workflows#658

Merged
credfeto merged 1 commit into
mainfrom
fix/653-cancel-workflows-output-helpers
Jun 5, 2026
Merged

fix: replace raw echo with standard output helpers in github/cancel-workflows#658
credfeto merged 1 commit into
mainfrom
fix/653-cancel-workflows-output-helpers

Conversation

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

Summary

  • Replace the custom inline info() and die() functions with the standard project output helpers (die, info, success), using coloured printf-based output per shell-scripts.examples.md
  • Add success call at end of script to confirm completion
  • Change shebang from #!/bin/bash to #!/bin/sh (no bash-specific features used)

Closes #653

Test plan

  • shellcheck github/cancel-workflows passes
  • checkbashisms github/cancel-workflows passes
  • Pre-commit hooks pass

@dnyw4l3n13 dnyw4l3n13 self-assigned this Jun 4, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 4, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 4, 2026 22:48
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator Author

PR marked as ready for review. CI checks are now running (previously skipped while in draft). No outstanding review comments or code issues to address.

@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 4, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator Author

All CI checks have passed:

  • BASH linting (Super-linter) ✅
  • lint-code
  • valid-changelog
  • change-log-entry-is-in-unreleased
  • include-changelog-entry
  • does-not-contain-secrets
  • dependency-review
  • has-no-merge-conflicts
  • has-no-file-or-folder-case-sensitivity-issues
  • no-merge-commits
  • no-ignored-files
  • build-pre-release

No review comments to address. PR is ready to merge.

…orkflows

Prompt: Replace raw echo with standard output helpers in github/cancel-workflows (issue #653)
@dnyw4l3n13 dnyw4l3n13 force-pushed the fix/653-cancel-workflows-output-helpers branch from 1775d85 to 7f4a9a6 Compare June 5, 2026 09:35
@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@credfeto credfeto enabled auto-merge June 5, 2026 10:42
@credfeto credfeto merged commit bb3432a into main Jun 5, 2026
28 checks passed
@credfeto credfeto deleted the fix/653-cancel-workflows-output-helpers branch June 5, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in github/cancel-workflows

2 participants