Skip to content

feat: add GitHub CLI comment body, label management, and CI check-once rules#846

Merged
credfeto merged 2 commits into
mainfrom
feat/github-cli-and-ci-rules
Jun 5, 2026
Merged

feat: add GitHub CLI comment body, label management, and CI check-once rules#846
credfeto merged 2 commits into
mainfrom
feat/github-cli-and-ci-rules

Conversation

@credfeto
Copy link
Copy Markdown
Owner

@credfeto credfeto commented Jun 5, 2026

Moves three rules out of the oneshot bootstrap prompts and into the global instruction files so they are loaded automatically by every Claude session without bloating prompts.

  • git.instructions.md: HEREDOC rule for gh comment bodies — never escaped \n
  • task-workflow.instructions.md: Label management — always --add-label, never --label, never remove labels
  • agent-roles.instructions.md: CI check-once policy under Orchestrator — check once, act immediately, never poll or --watch

Companion PR in credfeto-orchestrator removes the inline IMPORTANT blocks from build_issue_prompt and build_pr_prompt and replaces them with a one-line reminder to follow the AI instructions.

Copilot AI review requested due to automatic review settings June 5, 2026 14:09
@credfeto credfeto self-assigned this Jun 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes three frequently used operational rules from one-shot bootstrap prompts into always-loaded global instruction files so they apply consistently across sessions without enlarging prompts.

Changes:

  • Adds mandatory guidance to use HEREDOCs for multi-line gh comment/PR bodies (avoid literal \n rendering).
  • Adds mandatory label-management guidance to always use --add-label, never --label, and to never remove labels.
  • Adds an Orchestrator “check CI once” rule (no polling/--watch; act and stop).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
ai/global/task-workflow.instructions.md Introduces mandatory label-management rules (--add-label only; never remove labels).
ai/global/git.instructions.md Documents HEREDOC-based gh --body usage for multi-line content.
ai/global/agent-roles.instructions.md Adds Orchestrator CI “check once, act immediately, don’t poll” policy.

Comment thread ai/global/agent-roles.instructions.md Outdated
@credfeto
Copy link
Copy Markdown
Owner Author

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copilot AI review requested due to automatic review settings June 5, 2026 14:13
credfeto and others added 2 commits June 5, 2026 15:14
…e rules

- git.instructions.md: GitHub CLI comment bodies must use HEREDOC (never escaped \n)
- task-workflow.instructions.md: label management — always --add-label, never --label, never remove
- agent-roles.instructions.md: CI check-once policy under Orchestrator — check once, act immediately, never poll or --watch

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@credfeto credfeto force-pushed the feat/github-cli-and-ci-rules branch from 66d2b02 to 74f97cb Compare June 5, 2026 14:14
@credfeto credfeto merged commit d1ffe5c into main Jun 5, 2026
21 of 22 checks passed
@credfeto credfeto deleted the feat/github-cli-and-ci-rules branch June 5, 2026 14:14
@credfeto
Copy link
Copy Markdown
Owner Author

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment on lines +74 to +75
- Always use `--add-label` when adding labels — **never** `--label`, which replaces all existing labels and destroys automatically-applied classification labels.
- Never remove labels from issues or PRs. GitHub workflows add classification labels automatically; removing them breaks automation.
Comment on lines +47 to +49
- Any check pending or in_progress → post a brief status comment on the PR and stop. The orchestrator re-invokes the session automatically when the PR state changes (checks complete, review arrives, etc.).
- Any check failed → investigate, fix, push, post a status comment, and stop. Do not wait for the new run to complete.
- CI consistently failing and cannot be fixed → mark the PR blocked: `gh pr edit <number> --repo <owner/repo> --add-label "Blocked"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants