-
Notifications
You must be signed in to change notification settings - Fork 17
fix: minor UI enhancements #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 8bfcc0f in 1 minute and 38 seconds. Click for details.
- Reviewed
156lines of code in5files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/features/certificates/Certificates.tsx:166
- Draft comment:
Good early return for absence of organization (orgId) in list view. Consider verifying the user flow, ensuring users are directed to organization creation if needed. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/features/dashboard/components/dashboard.tsx:42
- Draft comment:
Introduction of 'hasOrganization' state improves clarity. Confirm that the logic correctly distinguishes between no organization and an empty wallet. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/features/organization/components/DeleteOrganization.tsx:219
- Draft comment:
Dispatching resetOrgState() after successful deletion helps clear stale org state. Confirm that this does not interfere with any onboarding logic. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_0q9aWg2IlG8GF3NK
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| type: 'Issuer Root', | ||
| keyType: 'P-256', | ||
| countryCode: 'NL', | ||
| countryCode: 'US', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent default country code: initial state uses 'US' but later resets to 'NL'. Use the same default consistently.
| countryCode: 'US', | |
| countryCode: 'NL', |
What
UI screens