Skip to content

Conversation

@pranalidhanavade
Copy link
Contributor

@pranalidhanavade pranalidhanavade commented Jan 14, 2026

What

  • Removed the unnecessary loader from the wallet details card.
  • Added conditional handling for the X.509 certificates list when the orgId is not available.

UI screens

Screenshot from 2026-01-14 11-30-37 Screenshot from 2026-01-14 11-30-45 Screenshot from 2026-01-14 11-31-31 Screenshot from 2026-01-14 11-36-47 Screenshot from 2026-01-14 11-36-56

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 8bfcc0f in 1 minute and 38 seconds. Click for details.
  • Reviewed 156 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/features/certificates/Certificates.tsx:166
  • Draft comment:
    Good early return for absence of organization (orgId) in list view. Consider verifying the user flow, ensuring users are directed to organization creation if needed.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. src/features/dashboard/components/dashboard.tsx:42
  • Draft comment:
    Introduction of 'hasOrganization' state improves clarity. Confirm that the logic correctly distinguishes between no organization and an empty wallet.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. src/features/organization/components/DeleteOrganization.tsx:219
  • Draft comment:
    Dispatching resetOrgState() after successful deletion helps clear stale org state. Confirm that this does not interfere with any onboarding logic.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_0q9aWg2IlG8GF3NK

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

type: 'Issuer Root',
keyType: 'P-256',
countryCode: 'NL',
countryCode: 'US',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent default country code: initial state uses 'US' but later resets to 'NL'. Use the same default consistently.

Suggested change
countryCode: 'US',
countryCode: 'NL',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants