feat: create intent API endpoints and intent template mapping APIs #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughMoves intent-template CRUD into the ecosystem domain, adds full intent and intent-template CRUD/query surfaces across API Gateway, Ecosystem services and repository, updates Prisma schema (ecosystemId on intents), and restores/extends platform invitation and ledger endpoints. (48 words) Changes
Sequence Diagram(s)sequenceDiagram
participant Client as "Client"
participant API as "API Gateway (Ecosystem Controller)"
participant Svc as "Ecosystem Service"
participant Repo as "Ecosystem Repository"
participant DB as "Database (Prisma)"
Client->>API: HTTP request (intent/template CRUD)
API->>Svc: validate & forward DTO
Svc->>Repo: perform create/read/update/delete
Repo->>DB: SQL via Prisma
DB-->>Repo: result
Repo-->>Svc: return data or error
Svc-->>API: standardized response / error
API-->>Client: HTTP response
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly Related PRs
Suggested Labels
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
…vice Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Contributor
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Contributor
Author
|
@coderabbitai full-review |
|
✅ Actions performedFull review triggered. |
Contributor
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 11
🤖 Fix all issues with AI agents
In `@apps/api-gateway/src/ecosystem/ecosystem.controller.ts`:
- Line 506: Add Nest's ParseUUIDPipe to validate UUID path params: update the
handler signature for getIntentTemplatesByIntentId to use `@Param`('intentId', new
ParseUUIDPipe()) intentId: string (and likewise add new ParseUUIDPipe() to any
other handlers that accept UUIDs—the ones referenced that accept orgId or id).
Import ParseUUIDPipe from `@nestjs/common` at the top of the file and apply the
same change to the other endpoints that take orgId/id so all path params are
consistently validated.
- Around line 737-738: Add UUID validation to the ecosystemId and intentId route
parameters by applying NestJS's ParseUUIDPipe (or equivalent UUID validation) to
the `@Param` decorators used in the intent handlers (e.g., the update and delete
intent methods that currently declare `@Param`('ecosystemId') ecosystemId: string
and `@Param`('intentId') intentId: string); update both parameter declarations
(also at the other occurrence noted) to use the ParseUUIDPipe so invalid UUIDs
are rejected before handler logic runs.
- Around line 625-627: The `@Roles`(OrgRoles.OWNER, OrgRoles.ADMIN) decorator on
the Post('/intents/:ecosystemId') handler is not enforced because OrgRolesGuard
is not applied; update the UseGuards on that handler (or controller) to include
OrgRolesGuard alongside AuthGuard('jwt') (e.g., UseGuards(AuthGuard('jwt'),
OrgRolesGuard)), and add the necessary import for OrgRolesGuard so the role
checks are executed for the method handling intents.
- Around line 410-412: The intent-template endpoints in ecosystem.controller.ts
(routes like POST '/intent-templates' and the related GET/PUT/DELETE handlers)
only use AuthGuard('jwt') and must enforce role-based access like the other
ecosystem endpoints; add `@Roles`(...) decorators with the appropriate roles
(e.g., Roles(Role.ADMIN, Role.SUPER_ADMIN) or whatever role set your repo uses)
to each intent-template handler, ensure RolesGuard is applied (e.g.,
`@UseGuards`(AuthGuard('jwt'), RolesGuard)), and add the necessary imports (Roles
decorator, RolesGuard, and Role enum) to the file so the
create/read/update/delete intent-template routes are protected consistently.
In `@apps/api-gateway/src/ecosystem/ecosystem.service.ts`:
- Around line 135-141: deleteIntentTemplate and getIntentTemplatesByOrgId are
sending raw strings to sendNatsMessage, causing payload format inconsistency;
update both methods to pass an object payload (e.g., { id: id } and { orgId:
orgId } or use shorthand { id } / { orgId }) to match the other calls to
natsClient.sendNatsMessage(this.serviceProxy, ...), so modify
deleteIntentTemplate and getIntentTemplatesByOrgId to wrap their string args in
objects before calling sendNatsMessage.
In `@apps/ecosystem/dtos/create-intent.dto.ts`:
- Around line 1-7: CreateIntentDto is missing DTO-level validation and Swagger
metadata for the required fields ecosystemId and userId; update the class
(extending IntentBaseDto) to add validation decorators (e.g., `@IsString` and
`@IsNotEmpty`) to both ecosystemId and userId and annotate each with Swagger
decorators (e.g., `@ApiProperty` with description and required: true) so they
match IntentBaseDto patterns and appear in generated docs even though values are
set by the controller.
In `@apps/ecosystem/dtos/update-intent.dto.ts`:
- Around line 1-8: UpdateIntentDto is missing validation and Swagger metadata
for intentId, ecosystemId, and userId; add class-validator decorators (e.g.,
`@IsUUID`() and `@IsNotEmpty`() as appropriate) and Swagger decorators (e.g.,
`@ApiProperty`({ type: 'string', format: 'uuid' })) to each of the three fields in
the UpdateIntentDto class to enforce UUID validation and generate proper docs,
and apply the same pattern to ecosystemId and userId in CreateIntentDto to keep
DTO validation consistent with IntentBaseDto’s approach.
In `@apps/ecosystem/repositories/ecosystem.repository.ts`:
- Around line 988-989: The pagination response sets previousPage to pageNumber -
1 which yields 0 when pageNumber === 1; update the logic in the repository
method that builds the pagination object (the fields nextPage and previousPage)
to return null (or clamp to 1) for previousPage when pageNumber <= 1 so
previousPage is never 0; adjust any callers that expect a nullable previousPage
accordingly and keep nextPage as Number(pageNumber) + 1.
In `@apps/ecosystem/src/ecosystem.controller.ts`:
- Around line 260-266: The getIntents method incorrectly uses the HTTP `@Body`()
decorator with a microservice `@MessagePattern`; remove the `@Body`() decorator and
accept the message payload as the plain method parameter (e.g., change signature
of getIntents to async getIntents(payload: any): Promise<object[]>), then
destructure ecosystemId and intentId from payload and call
this.ecosystemService.getIntents(ecosystemId, intentId); ensure you update the
import usage if any and consider replacing the any type with a proper DTO later.
In `@libs/common/src/response-messages/index.ts`:
- Around line 199-200: The messages for the keys fetchIntentTemplates and
fetchVerificationTemplates are inconsistent: update the value for
fetchIntentTemplates to reference "intent template(s)" (e.g., "Ecosystem intent
templates fetched successfully") and remove the leading space in
fetchVerificationTemplates while harmonizing wording/capitalization (e.g.,
"Verification templates fetched successfully") so both messages align with their
keys.
In
`@libs/prisma-service/prisma/migrations/20260119130717_intent_table_creation/migration.sql`:
- Around line 4-11: The migration currently adds ecosystemId to the intents
table as NOT NULL which can break workflows and differs from the
ecosystem_invitations pattern; update the migration to either (A) add
"ecosystemId" as NULLABLE on table "intents" and keep the foreign key constraint
"intents_ecosystemId_fkey" (enforce non-null/uniqueness in application logic),
or (B) convert this to a two-step migration: first ALTER TABLE "intents" ADD
COLUMN "ecosystemId" UUID NULL and add the FK constraint, then in a subsequent
migration backfill existing rows and ALTER TABLE "intents" ALTER COLUMN
"ecosystemId" SET NOT NULL; adjust the migration.sql to use the chosen approach
and ensure constraint name "intents_ecosystemId_fkey" remains correct.
🧹 Nitpick comments (17)
libs/prisma-service/prisma/seed.ts (1)
1-1: Narrow the ESLint disable scope.File-level
camelcasedisable can hide new violations; consider// eslint-disable-next-line camelcaseon the specific lines instead.libs/prisma-service/prisma/schema.prisma (1)
706-716: Add an index onintents.ecosystemIdto align with codebase patterns.The codebase consistently indexes FK relationships (e.g.,
cities.stateId,verification_templates.orgId,intent_templates.intentId). Sinceintent_templatesindexesintentId(the FK tointents), queries on theintentsmodel by ecosystem are likely expected. Postgres doesn't auto-index FK columns, so add an index for performance consistency.♻️ Proposed change
model intents { id String `@id` `@default`(uuid()) `@db.Uuid` ecosystemId String `@db.Uuid` name String `@db.VarChar`(500) description String? createDateTime DateTime `@default`(now()) `@db.Timestamptz`(6) createdBy String `@db.Uuid` lastChangedDateTime DateTime `@default`(now()) `@db.Timestamptz`(6) lastChangedBy String `@db.Uuid` ecosystem ecosystem `@relation`(fields: [ecosystemId], references: [id]) intentTemplates intent_templates[] + @@index([ecosystemId]) }apps/api-gateway/src/platform/platform.controller.ts (3)
168-183: Redundant validation: route parameter cannot be empty.The
indyNamespacecheck on line 172 is likely unreachable. NestJS route parameters are required by default, so a request to/platform/network/url/without a value would result in a 404 (route not found) rather than reaching this handler. TheTrimStringParamPipecould trim to empty string, but the validation message implies a missing parameter scenario.Consider whether you need this check, or if you want to validate against whitespace-only input:
♻️ Suggested refinement
async getNetwrkUrl( `@Param`('indyNamespace', TrimStringParamPipe) indyNamespace: string, `@Res`() res: Response ): Promise<Response> { - if (!indyNamespace) { - throw new BadRequestException(ResponseMessages.ledger.error.indyNamespaceisRequired); - } + // TrimStringParamPipe handles trimming; empty check is defensive + if (!indyNamespace?.trim()) { + throw new BadRequestException(ResponseMessages.ledger.error.indyNamespaceisRequired); + }
239-250: Minor: Inconsistent response construction pattern.This endpoint constructs the response inline without using the
IResponsetype, while other endpoints in the same controller useconst finalResponse: IResponse = {...}. Consider aligning for consistency.♻️ Suggested fix
async createInvitation( `@Body`() createEcosystemInvitationDto: CreateEcosystemInvitationDto, `@User`() reqUser: user, `@Res`() res: Response ): Promise<Response> { await this.platformService.inviteUserToCreateEcosystem(createEcosystemInvitationDto.email, reqUser.id); - return res.status(HttpStatus.CREATED).json({ - statusCode: HttpStatus.CREATED, - message: ResponseMessages.ecosystem.success.createInvitation - }); + const finalResponse: IResponse = { + statusCode: HttpStatus.CREATED, + message: ResponseMessages.ecosystem.success.createInvitation + }; + return res.status(HttpStatus.CREATED).json(finalResponse); }
269-277: Minor: Same response pattern inconsistency.Similar to the
createInvitationendpoint, consider using theIResponsetype for consistency with other endpoints.♻️ Suggested fix
async getInvitations(`@User`() reqUser: user, `@Res`() res: Response): Promise<Response> { const invitations = await this.platformService.getInvitationsByUserId(reqUser.id); - return res.status(HttpStatus.OK).json({ - statusCode: HttpStatus.OK, - message: ResponseMessages.ecosystem.success.fetch, - data: invitations - }); + const finalResponse: IResponse = { + statusCode: HttpStatus.OK, + message: ResponseMessages.ecosystem.success.fetch, + data: invitations + }; + return res.status(HttpStatus.OK).json(finalResponse); }apps/api-gateway/src/ecosystem/ecosystem.service.ts (1)
150-154: Unnecessary nesting in payload.The
createIntentmethod wrapscreateIntentDtoin another object{ createIntentDto }. If the receiving handler destructures expectingcreateIntentDto, this is fine, but verify consistency with the receiver.apps/ecosystem/src/ecosystem.service.ts (5)
473-488: Inconsistent error handling: Use RpcException for "not found".Line 477 throws a generic
Errorfor "not found", which will be caught and re-categorized byErrorHandler.categorize. Other methods in this PR useRpcExceptiondirectly for similar conditions (e.g.,createIntentTemplateat lines 430-433). Consider usingRpcExceptionwith a proper status code for consistency and clearer error semantics.♻️ Suggested fix
async getIntentTemplateById(id: string): Promise<object> { try { const intentTemplate = await this.ecosystemRepository.getIntentTemplateById(id); if (!intentTemplate) { - throw new Error('Intent template not found'); + throw new RpcException({ + statusCode: HttpStatus.NOT_FOUND, + message: 'Intent template not found' + }); } return intentTemplate; } catch (error) {
593-615: Inconsistent error throwing:BadRequestExceptionvsRpcException.The
createIntentmethod throwsBadRequestExceptiondirectly (line 598), while other methods in this service useRpcExceptionfor validation errors. In a microservice context,RpcExceptionis the preferred exception type as it properly propagates through the message transport.♻️ Suggested fix
async createIntent(createIntentDto: CreateIntentDto): Promise<object> { try { const { name, description, ecosystemId, userId } = createIntentDto; if (!name || !ecosystemId || !userId) { - throw new BadRequestException('name, ecosystemId and userId are required'); + throw new RpcException({ + statusCode: HttpStatus.BAD_REQUEST, + message: 'name, ecosystemId and userId are required' + }); }
644-669: Same issue: GenericErrorthrown for validation.Line 649 throws a generic
Errorinstead ofRpcException. Apply the same fix pattern as above.♻️ Suggested fix
if (!intentId || !ecosystemId) { - throw new Error('Invalid intentId and ecosystemId are required'); + throw new RpcException({ + statusCode: HttpStatus.BAD_REQUEST, + message: 'intentId and ecosystemId are required' + }); }
671-683: Same issue:BadRequestExceptionin microservice context.
deleteIntentusesBadRequestExceptiondirectly. UseRpcExceptionfor consistency.♻️ Suggested fix
async deleteIntent(ecosystemId: string, intentId: string, user: { id: string }): Promise<object> { if (!ecosystemId || !intentId || !user?.id) { - throw new BadRequestException('ecosystemId, intentId and user are required'); + throw new RpcException({ + statusCode: HttpStatus.BAD_REQUEST, + message: 'ecosystemId, intentId and user are required' + }); }
633-639: Missing error handling ingetTemplatesByIntentId.Unlike other methods,
getTemplatesByIntentIddoesn't have try-catch withErrorHandler. This could cause unhandled errors to propagate differently than expected.♻️ Suggested fix
async getTemplatesByIntentId(orgId: string): Promise<object[]> { if (!orgId) { - throw new BadRequestException('orgId is required'); + throw new RpcException({ + statusCode: HttpStatus.BAD_REQUEST, + message: 'orgId is required' + }); } - return this.ecosystemRepository.getTemplatesByEcosystemId(orgId); + try { + return await this.ecosystemRepository.getTemplatesByEcosystemId(orgId); + } catch (error) { + const errorResponse = ErrorHandler.categorize(error, 'Failed to retrieve templates'); + this.logger.error( + `[getTemplatesByIntentId] - ${errorResponse.statusCode}: ${errorResponse.message}`, + ErrorHandler.format(error) + ); + throw new RpcException(errorResponse); + } }apps/api-gateway/src/ecosystem/ecosystem.controller.ts (3)
724-726: Update intent endpoint missing role-based guard.Similar to
createIntent, this mutation endpoint has no@Rolesdecorator or role guard. Consider adding authorization to restrict who can update intents.♻️ Proposed fix
`@Put`('/intents/:ecosystemId/:intentId') + `@Roles`(OrgRoles.OWNER, OrgRoles.ADMIN) + `@UseGuards`(AuthGuard('jwt'), OrgRolesGuard) `@ApiBearerAuth`() - `@UseGuards`(AuthGuard('jwt')) `@ApiOperation`({
763-765: Delete intent endpoint missing role-based guard.Delete operations should typically require elevated permissions. Consider adding role-based authorization.
♻️ Proposed fix
`@Delete`('/intents/:ecosystemId/:intentId') + `@Roles`(OrgRoles.OWNER, OrgRoles.ADMIN) + `@UseGuards`(AuthGuard('jwt'), OrgRolesGuard) `@ApiBearerAuth`() - `@UseGuards`(AuthGuard('jwt')) `@ApiOperation`({
708-708: Method namegetTemplateByIntentIdis misleading.The method fetches templates by
orgId, not byintentId. Consider renaming for clarity.apps/ecosystem/repositories/ecosystem.repository.ts (3)
645-660: Missing error handling increateIntentTemplate.Unlike other repository methods, this lacks try-catch error handling. Prisma errors (e.g., unique constraint violations, FK errors) will propagate unhandled.
♻️ Proposed fix
async createIntentTemplate(data: { orgId?: string; intentId: string; templateId: string; createdBy: string; }): Promise<intent_templates> { + try { return this.prisma.intent_templates.create({ data: { orgId: data.orgId ?? null, intentId: data.intentId, templateId: data.templateId, createdBy: data.createdBy, lastChangedBy: data.createdBy } }); + } catch (error) { + this.logger.error(`Error in createIntentTemplate: ${error}`); + throw error; + } }
1091-1091: Method parameter name is misleading.The method
getTemplatesByEcosystemIdtakesorgIdas parameter, but the name suggests it takes an ecosystem ID. The query logic fetches templates for organizations within an ecosystem.♻️ Consider renaming for clarity
- async getTemplatesByEcosystemId(orgId: string): Promise<verification_templates[]> { + async getTemplatesByOrgEcosystem(orgId: string): Promise<verification_templates[]> {Or update the implementation to actually accept
ecosystemIdif that was the intent.
1162-1167: UsingdeleteManyfor a single record deletion.Since the intent is found by unique
idandecosystemId, usingdeletewould be more appropriate and semantically correct.♻️ Proposed fix
- await this.prisma.intents.deleteMany({ - where: { - id: data.intentId, - ecosystemId: data.ecosystemId - } - }); + await this.prisma.intents.delete({ + where: { id: data.intentId } + });
libs/prisma-service/prisma/migrations/20260119130717_intent_table_creation/migration.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 10
🤖 Fix all issues with AI agents
In `@apps/api-gateway/src/platform/platform.controller.ts`:
- Around line 209-219: In getQrCode, stop using process.env directly and inject
Nest's ConfigService to build the URL (use
ConfigService.get('API_GATEWAY_PROTOCOL') and
ConfigService.get('API_ENDPOINT')), wrap the QRCode.toBuffer call in a try/catch
to handle generation errors and respond with a proper error status/log (e.g.,
log the error via this.logger and res.status(500).send()), and if this endpoint
should be protected add the appropriate auth guard or decorator to the getQrCode
route to match the shortening URL's authentication pattern.
In `@apps/api-gateway/src/platform/platform.service.ts`:
- Around line 48-58: Update the incorrect JSDoc for inviteUserToCreateEcosystem
to reflect the actual parameters: replace the `@param`
createEcosystemInvitationDto entry with `@param` email {string} and `@param`
platformAdminId {string}, and adjust the `@returns` description to match the
Promise<IEcosystemInvitations> return type; ensure the JSDoc sits above the
async inviteUserToCreateEcosystem(email: string, platformAdminId: string):
Promise<IEcosystemInvitations> declaration so it documents the function used
with this.natsClient.sendNatsMessage and accurately describes inputs and return
value.
In `@apps/ecosystem/repositories/ecosystem.repository.ts`:
- Around line 943-961: The code uses intentTemplateSearchCriteria.sortField
directly to build orderByField for prisma.intent_templates.findMany which can
throw if the field is invalid; add a validation step that checks
intentTemplateSearchCriteria.sortField against an allowlist of permitted columns
(e.g., ['createDateTime','id','createdBy','intentId','templateId','orgId']) and
only assign orderByField from intentTemplateSearchCriteria.sortField when it
exists in that allowlist, otherwise fallback to the existing default
'createDateTime'; ensure the orderBy usage in the findMany call remains
unchanged and still uses the computed orderByField and orderDirection.
- Around line 560-578: getEcosystemById and getPlatformConfigData currently call
prisma.findFirst() (which may return null) but are typed as non-null; update
each to handle nulls: after awaiting this.prisma.ecosystem.findFirst({ where: {
id } }) in getEcosystemById check if result is null and throw a
NotFoundException (include the id in the message) or alternatively change the
method signature to return Promise<ecosystem | null>; do the same for
getPlatformConfigData (throw a NotFoundException like "Platform config not
found" or return Promise<platform_config | null>), and keep logging the error on
exceptions as currently implemented.
- Around line 582-595: The getIntentTemplateById method currently assumes
prisma.findUnique returns a value and logs success even when it may be null;
update getIntentTemplateById to handle the null case by either changing the
return type to Promise<intent_templates | null> and returning null (and log a
"not found" message) or keep Promise<intent_templates> and throw a NotFoundError
when intentTemplate is null; adjust the logging so this.logger.log(...) is only
called on a successful find and add this.logger.warn(...) or
this.logger.error(...) for the not-found branch; target the
getIntentTemplateById function and the local variable intentTemplate in your
change.
- Around line 693-707: The updateIntentTemplate function currently requires
orgId as a non-null string which prevents updating global templates; change the
parameter signature in updateIntentTemplate to accept orgId?: string | null
(matching createIntentTemplate) and when building the Prisma update payload set
orgId to null when missing (e.g. use data.orgId ?? null) so templates with a
null orgId can be updated; locate the logic in updateIntentTemplate and adjust
the parameter type and the data.orgId assignment accordingly.
- Around line 1091-1104: Rename the method getTemplatesByEcosystemId to
getTemplatesByOrgId to match the orgId parameter and query; update the function
declaration and any internal references (the async function signature and usages
of getTemplatesByEcosystemId) and adjust any exported API or tests that call it.
Locate the prisma query in verification_templates.findMany inside
ecosystem.repository.ts and change the method name, then run a project-wide
search/replace for getTemplatesByEcosystemId → getTemplatesByOrgId to update
callers and exports (keeping the orgId parameter and existing query logic
unchanged).
- Around line 733-762: The getIntentTemplateByIntentAndOrg function queries
intent_templates by intent name and verifierOrgId but does not scope by
ecosystem, so it can return templates from the wrong ecosystem; update the
function signature (getIntentTemplateByIntentAndOrg) to accept an ecosystem
identifier (e.g., ecosystemId), and add an ecosystem filter to the Prisma query
(use organisation.ecosystemId or intent/intent_templates related ecosystem
field) alongside the existing OR on orgId so results are constrained to the
correct ecosystem; ensure the select and orderBy remain unchanged and adjust any
callers to pass the new ecosystemId parameter.
In `@apps/ecosystem/src/ecosystem.service.ts`:
- Around line 473-488: Replace the generic Error throw in getIntentTemplateById
with a NestJS NotFoundException to be explicit: when
ecosystemRepository.getIntentTemplateById(id) returns falsy, throw new
NotFoundException('Intent template not found'); ensure NotFoundException is
imported from `@nestjs/common`; keep the existing catch that uses
ErrorHandler.categorize/format and rethrows RpcException so error logging and
RPC behavior remain unchanged.
- Around line 644-657: In updateIntent (async updateIntent(updateIntentDto:
UpdateIntentDto)), validate that userId exists before calling
ecosystemRepository.updateIntent: check the extracted const { intentId,
ecosystemId, name, description, userId } (or ensure userId is read) and if
missing throw a BadRequestException (not a generic Error) consistent with
createIntent/getTemplatesByIntentId; then call
this.ecosystemRepository.updateIntent with lastChangedBy set to the validated
userId.
♻️ Duplicate comments (9)
libs/prisma-service/prisma/migrations/20260119130717_intent_table_creation/migration.sql (1)
1-11: Consider makingecosystemIdnullable or using a two-step migration.Adding a required column without a default can break non-empty tables; nullable → backfill → NOT NULL is safer.
🛠️ Example (nullable first step)
-ALTER TABLE "intents" ADD COLUMN "ecosystemId" UUID NOT NULL; +ALTER TABLE "intents" ADD COLUMN "ecosystemId" UUID;libs/common/src/response-messages/index.ts (1)
195-200: Fix message wording for intent templates and verification templates.🛠️ Suggested fix
- fetchIntentTemplates: 'Ecosystem intent fetched successfully by id', - fetchVerificationTemplates: ' Verification templates fetched successfully' + fetchIntentTemplates: 'Ecosystem intent templates fetched successfully', + fetchVerificationTemplates: 'Verification templates fetched successfully'apps/ecosystem/dtos/create-intent.dto.ts (1)
1-7: Add validation & Swagger metadata forecosystemIdanduserId.These fields are required and should match the validation patterns used in other DTOs.
🛠️ Suggested fix
-import { ApiExtraModels } from '@nestjs/swagger'; +import { ApiExtraModels, ApiProperty } from '@nestjs/swagger'; +import { IsNotEmpty, IsUUID } from 'class-validator'; import { IntentBaseDto } from './intent-base.dto'; `@ApiExtraModels`() export class CreateIntentDto extends IntentBaseDto { - ecosystemId: string; - userId: string; + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + ecosystemId: string; + + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + userId: string; }#!/bin/bash # Verify DTO validation patterns used elsewhere for UUID fields rg -n "@IsUUID" apps/ecosystem/dtos -g "*.ts" rg -n "CreateIntentDto" -C3 apps/ecosystemapps/ecosystem/dtos/update-intent.dto.ts (1)
1-8: Add UUID validation & Swagger metadata for ID fields.
intentId,ecosystemId, anduserIdare unvalidated strings. Align with the existing DTO patterns by adding@ApiProperty({ format: 'uuid' }),@IsUUID(), and@IsNotEmpty()to prevent invalid IDs and keep the Swagger contract accurate.🔧 Suggested fix
-import { ApiExtraModels } from '@nestjs/swagger'; +import { ApiExtraModels, ApiProperty } from '@nestjs/swagger'; +import { IsNotEmpty, IsUUID } from 'class-validator'; import { IntentBaseDto } from './intent-base.dto'; `@ApiExtraModels`() export class UpdateIntentDto extends IntentBaseDto { - intentId: string; - ecosystemId: string; - userId: string; + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + intentId: string; + + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + ecosystemId: string; + + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + userId: string; }apps/api-gateway/src/ecosystem/ecosystem.controller.ts (3)
410-617: Intent-template endpoints need role-based guards.All intent-template routes are guarded only by
AuthGuard('jwt'). If these are meant to be restricted (as other ecosystem routes are), add@Roles(...)and the appropriate roles guard to each handler.
625-628:@Roleson createIntent is not enforced withoutOrgRolesGuard.
@Roles(OrgRoles.OWNER, OrgRoles.ADMIN)has no effect unless the roles guard is applied.🔧 Suggested fix
`@Post`('/intents/:ecosystemId') `@Roles`(OrgRoles.OWNER, OrgRoles.ADMIN) -@UseGuards(AuthGuard('jwt')) +@UseGuards(AuthGuard('jwt'), OrgRolesGuard) `@ApiBearerAuth`()
498-531: Add UUID validation for path params (intentId,orgId,ecosystemId).Several routes accept UUID path params without
ParseUUIDPipe, unlikegetIntentTemplateById. Consistent validation prevents invalid IDs from reaching the service layer.🔧 Example fix (apply similarly to other UUID params)
-async getIntentTemplatesByIntentId(`@Param`('intentId') intentId: string, `@Res`() res: Response): Promise<Response> { +async getIntentTemplatesByIntentId( + `@Param`( + 'intentId', + new ParseUUIDPipe({ + exceptionFactory: (): Error => { + throw new BadRequestException('Invalid intent ID format'); + } + }) + ) + intentId: string, + `@Res`() res: Response +): Promise<Response> {Also applies to: 579-610, 724-777
apps/ecosystem/src/ecosystem.controller.ts (1)
1-1: Don’t use@Body()with@MessagePatternpayloads.In NestJS microservices, the payload is passed directly to the handler. Using
@Body()here can yieldundefinedor malformed payloads.🔧 Suggested fix
-import { Body, Controller, Logger } from '@nestjs/common'; +import { Controller, Logger } from '@nestjs/common'; ... `@MessagePattern`({ cmd: 'get-intents' }) -// eslint-disable-next-line `@typescript-eslint/no-explicit-any` -async getIntents(`@Body`() payload: any): Promise<object[]> { +async getIntents(payload: { ecosystemId: string; intentId?: string }): Promise<object[]> { const { ecosystemId, intentId } = payload;Also applies to: 260-263
apps/ecosystem/repositories/ecosystem.repository.ts (1)
984-990: previousPage can be 0 on the first page.When
pageNumber === 1,previousPagebecomes 0 (Line 988-989), which is not a valid page number.
🧹 Nitpick comments (7)
apps/utility/src/utilities.repository.ts (1)
14-14: Consider adding type annotations for method parameters.The
payloadparameter lacks a type annotation. Similarly,referenceIdon line 32 is untyped. Adding explicit types improves type safety and IDE support.💡 Suggested type annotations
- async saveShorteningUrl(payload): Promise<object> { + async saveShorteningUrl(payload: { referenceId: string; invitationPayload: string }): Promise<object> {- async getShorteningUrl(referenceId): Promise<shortening_url> { + async getShorteningUrl(referenceId: string): Promise<shortening_url> {apps/api-gateway/src/platform/platform.service.ts (1)
10-10: Cross-module import path may be fragile.The import uses a relative path reaching into
apps/ecosystem/interfaces. This creates a tight coupling between the API gateway and ecosystem modules. Consider exporting shared interfaces from a common library (e.g.,@credebl/common/interfaces) for better maintainability.apps/api-gateway/src/platform/platform.controller.ts (3)
142-151: Return type inconsistency.The method returns
Promise<object>while other similar methods returnPromise<Response>. For consistency, update the return type.♻️ Proposed fix
- async getAllLedgers(`@Res`() res: Response): Promise<object> { + async getAllLedgers(`@Res`() res: Response): Promise<Response> {
168-183: Typo in method name.The method name
getNetwrkUrlis missing the 'o' in 'Network'. Consider renaming togetNetworkUrlfor clarity.♻️ Proposed fix
- async getNetwrkUrl( + async getNetworkUrl(
239-250: Created resource not returned in response.The
inviteUserToCreateEcosystemresult is awaited but discarded. Consider returning the created invitation in the response body, which is a common REST pattern for POST endpoints and allows clients to access the created resource's ID without an additional request.♻️ Proposed fix
async createInvitation( `@Body`() createEcosystemInvitationDto: CreateEcosystemInvitationDto, `@User`() reqUser: user, `@Res`() res: Response ): Promise<Response> { - await this.platformService.inviteUserToCreateEcosystem(createEcosystemInvitationDto.email, reqUser.id); + const invitation = await this.platformService.inviteUserToCreateEcosystem(createEcosystemInvitationDto.email, reqUser.id); return res.status(HttpStatus.CREATED).json({ statusCode: HttpStatus.CREATED, - message: ResponseMessages.ecosystem.success.createInvitation + message: ResponseMessages.ecosystem.success.createInvitation, + data: invitation }); }libs/prisma-service/prisma/schema.prisma (1)
706-716: Consider indexingintents.ecosystemIdfor query performance.Most intent queries will likely filter by ecosystem; an index will help.
🛠️ Suggested change
model intents { id String `@id` `@default`(uuid()) `@db.Uuid` ecosystemId String `@db.Uuid` name String `@db.VarChar`(500) description String? createDateTime DateTime `@default`(now()) `@db.Timestamptz`(6) createdBy String `@db.Uuid` lastChangedDateTime DateTime `@default`(now()) `@db.Timestamptz`(6) lastChangedBy String `@db.Uuid` ecosystem ecosystem `@relation`(fields: [ecosystemId], references: [id]) intentTemplates intent_templates[] + + @@index([ecosystemId]) }apps/ecosystem/src/ecosystem.service.ts (1)
633-639: RenamegetTemplatesByIntentIdto reflect theorgIdparameter.The method name suggests an intentId lookup, but it accepts
orgIdand callsgetTemplatesByEcosystemId. Renaming to something likegetTemplatesByOrgId(or adjusting the parameter) would reduce confusion.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@apps/api-gateway/src/ecosystem/ecosystem.controller.ts`:
- Around line 658-679: The getIntents method is missing UUID validation for the
ecosystemId parameter; update the `@Param` decorator to use ParseUUIDPipe (as used
elsewhere) so the signature becomes `@Param`('ecosystemId', new ParseUUIDPipe())
ecosystemId: string and ensure ParseUUIDPipe is imported from `@nestjs/common`;
this enforces UUID format consistency for the getIntents handler.
In `@apps/api-gateway/src/ecosystem/ecosystem.service.ts`:
- Around line 113-133: The payloads sent from createIntentTemplate and
updateIntentTemplate (and the other method at lines ~202–203) forward the
IUserRequest object directly but the ecosystem service expects user.id, not
user.userId; update those methods (createIntentTemplate, updateIntentTemplate
and the other senders of `user: IUserRequest`) to normalize the user field by
mapping user.userId → id (e.g., build payload.user = { ...user, id: user.userId
} or set id explicitly) before calling this.natsClient.sendNatsMessage so the
downstream checks for user.id succeed.
In `@apps/api-gateway/src/platform/platform.controller.ts`:
- Around line 58-62: The Swagger query param name in the platform controller is
mismatched with the DTO: change the ApiQuery decorator on the get-all endpoint
to use the DTO's field name "sorting" (instead of "sortField") so Swagger docs
and NestJS binding align with GetAllSchemaByPlatformDto; update the ApiQuery
name property that currently references SortFields to "sorting" (or
alternatively rename the DTO field to match the existing "sortField") and ensure
enum remains SortFields so clients and the controller receive the value
correctly.
In `@apps/ecosystem/src/ecosystem.service.ts`:
- Around line 555-565: The updateIntentTemplate method dereferences user.id
without validation; add the same guard used in createIntentTemplate: verify that
data.user and data.user.id exist and are non-empty, and if not throw new
RpcException({ code: HttpStatus.BAD_REQUEST, message: 'user.id is required' })
(or the exact message pattern used in createIntentTemplate) before calling
this.ecosystemRepository.updateIntentTemplate, ensuring lastChangedBy is only
set from a validated user.id.
♻️ Duplicate comments (15)
apps/api-gateway/src/platform/platform.service.ts (1)
48-53: JSDoc doesn’t match the method signature.The comment still references
createEcosystemInvitationDtoand a generic success return, but the method accepts(email, platformAdminId)and returnsIEcosystemInvitations. Please align the JSDoc with the actual parameters/return type.📝 Suggested JSDoc update
- /** - * - * `@param` createEcosystemInvitationDto - * `@returns` Ecosystem creation success - */ + /** + * Invites a user to create an ecosystem + * `@param` email - The email address of the user to invite + * `@param` platformAdminId - The platform admin ID issuing the invitation + * `@returns` The created invitation record + */apps/api-gateway/src/platform/platform.controller.ts (1)
202-219: Add error handling + avoid direct env access (already flagged).
QRCode.toBuffer()can throw, and directprocess.envaccess bypasses config validation/typing. Consider try/catch +ConfigService.Is QRCode.toBuffer documented to throw/reject on invalid input or generation failure in the qrcode npm package?apps/ecosystem/repositories/ecosystem.repository.ts (6)
1091-1115: RenamegetTemplatesByEcosystemIdto match theorgIdparameter.The method name suggests ecosystem filtering, but it actually filters by org membership.
560-579: Handle null results fromfindFirst.Line 562 and Line 574 can return
null, but the methods are typed as non‑null. Either throwNotFoundExceptionor return nullable types.🐛 Proposed guard
async getEcosystemById(id: string): Promise<ecosystem> { try { const result = await this.prisma.ecosystem.findFirst({ where: { id } }); + if (!result) { + throw new NotFoundException('Ecosystem not found'); + } return result; } catch (error) { this.logger.error(`Error in getEcosystemById: ${error.message}`); throw error; } } async getPlatformConfigData(): Promise<platform_config> { try { - return await this.prisma.platform_config.findFirst(); + const config = await this.prisma.platform_config.findFirst(); + if (!config) { + throw new NotFoundException('Platform config not found'); + } + return config; } catch (error) { this.logger.error(`Error in getPlatformConfigData: ${error.message}`); throw error; } }
582-595: Guard against missing intent templates.Line 584 can return
null, but the method returnsPromise<intent_templates>and logs success even when not found.🐛 Proposed guard
const intentTemplate = await this.prisma.intent_templates.findUnique({ where: { id }, include: { organisation: true, intent: true, template: true } }); +if (!intentTemplate) { + throw new NotFoundException('Intent template not found'); +} this.logger.log(`[getIntentTemplateById] - Intent template details ${id}`); return intentTemplate;
693-707: AlloworgIdto be nullable on update.Line 695 requires
orgId, butcreateIntentTemplateallowsnull, so global templates can’t be updated.♻️ Suggested fix
- async updateIntentTemplate( - id: string, - data: { orgId: string; intentId: string; templateId: string; lastChangedBy: string } - ): Promise<intent_templates> { + async updateIntentTemplate( + id: string, + data: { orgId?: string | null; intentId: string; templateId: string; lastChangedBy: string } + ): Promise<intent_templates> { ... - orgId: data.orgId, + orgId: data.orgId ?? null,
733-762: Scope intent-template lookup by ecosystem.Line 737 filters by intent name and org only. If an org belongs to multiple ecosystems, this can return a template from the wrong ecosystem. Add
ecosystemIdto the filter and method signature.🐛 Suggested fix (signature + filter)
-async getIntentTemplateByIntentAndOrg(intentName: string, verifierOrgId: string) +async getIntentTemplateByIntentAndOrg(intentName: string, verifierOrgId: string, ecosystemId: string) ... - intent: { is: { name: intentName } }, + intent: { is: { name: intentName, ecosystemId } },
907-992: Harden sort field and pagination metadata.Line 943 uses a client‑provided
sortFielddirectly (invalid fields will throw). Line 989 can returnpreviousPage = 0. Add an allowlist and clamp.♻️ Suggested fix
-const orderByField = intentTemplateSearchCriteria.sortField || 'createDateTime'; +const allowedSortFields = new Set(['createDateTime', 'intentId', 'templateId', 'orgId', 'id']); +const requestedSortField = intentTemplateSearchCriteria.sortField || 'createDateTime'; +const orderByField = allowedSortFields.has(requestedSortField) ? requestedSortField : 'createDateTime'; ... -previousPage: pageNumber - 1, +previousPage: hasPreviousPage ? pageNumber - 1 : 1,libs/prisma-service/prisma/migrations/20260119130717_intent_table_creation/migration.sql (1)
1-11: Avoid adding a NOT NULL column without backfill.Line 8 adds
ecosystemIdas NOT NULL, which will fail ifintentsis non‑empty. Consider a two‑step migration (add nullable → backfill → set NOT NULL) or make it nullable if the workflow allows it.🛠️ Safer migration approach (step 1)
-ALTER TABLE "intents" ADD COLUMN "ecosystemId" UUID NOT NULL; +ALTER TABLE "intents" ADD COLUMN "ecosystemId" UUID;libs/common/src/response-messages/index.ts (1)
194-200: Fix intent-template success message text.Line 199 refers to a single intent rather than intent templates, and Line 200 has a leading space.
🛠️ Suggested fix
- fetchIntentTemplates: 'Ecosystem intent fetched successfully by id', - fetchVerificationTemplates: ' Verification templates fetched successfully' + fetchIntentTemplates: 'Ecosystem intent templates fetched successfully', + fetchVerificationTemplates: 'Verification templates fetched successfully'apps/ecosystem/dtos/create-intent.dto.ts (1)
1-7: Add validation and Swagger metadata for ID fields.Line 6–7 lacks UUID validation and Swagger docs, which makes API contracts weaker.
✅ Suggested fix
-import { ApiExtraModels } from '@nestjs/swagger'; +import { ApiExtraModels, ApiProperty } from '@nestjs/swagger'; +import { IsNotEmpty, IsUUID } from 'class-validator'; import { IntentBaseDto } from './intent-base.dto'; `@ApiExtraModels`() export class CreateIntentDto extends IntentBaseDto { - ecosystemId: string; - userId: string; + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + ecosystemId: string; + + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + userId: string; }apps/ecosystem/dtos/update-intent.dto.ts (1)
1-8: Add validation and Swagger metadata for ID fields.Line 6–8 are required identifiers but aren’t validated or documented.
✅ Suggested fix
-import { ApiExtraModels } from '@nestjs/swagger'; +import { ApiExtraModels, ApiProperty } from '@nestjs/swagger'; +import { IsNotEmpty, IsUUID } from 'class-validator'; import { IntentBaseDto } from './intent-base.dto'; `@ApiExtraModels`() export class UpdateIntentDto extends IntentBaseDto { - intentId: string; - ecosystemId: string; - userId: string; + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + intentId: string; + + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + ecosystemId: string; + + `@ApiProperty`({ format: 'uuid' }) + `@IsUUID`() + `@IsNotEmpty`() + userId: string; }apps/api-gateway/src/ecosystem/ecosystem.controller.ts (2)
410-618: Add role-based guards for intent-template CRUD endpoints.
Lines 410–618 only applyAuthGuard('jwt'), so any authenticated user can create/update/delete intent templates. Add@Roles(...)+ the appropriate roles guard (OrgRolesGuard/EcosystemRolesGuard) or move the guard to the controller level.
625-628:@Rolesis not enforced withoutOrgRolesGuard.
Line 627 applies@Roles(...)but the guard stack only includesAuthGuard('jwt'), so role checks won’t run.🔒 Suggested fix
`@Post`('/intents/:ecosystemId') `@Roles`(OrgRoles.OWNER, OrgRoles.ADMIN) - `@UseGuards`(AuthGuard('jwt')) + `@UseGuards`(AuthGuard('jwt'), OrgRolesGuard) `@ApiBearerAuth`()apps/ecosystem/src/ecosystem.controller.ts (1)
260-265: Remove@Body()from the@MessagePatternhandler.
Line 262 uses an HTTP decorator inside a microservice handler, which can result inpayloadbeing undefined. Accept the payload directly.🔧 Suggested fix
`@MessagePattern`({ cmd: 'get-intents' }) // eslint-disable-next-line `@typescript-eslint/no-explicit-any` - async getIntents(`@Body`() payload: any): Promise<object[]> { + async getIntents(payload: any): Promise<object[]> { const { ecosystemId, intentId } = payload; return this.ecosystemService.getIntents(ecosystemId, intentId); }
🧹 Nitpick comments (2)
apps/api-gateway/src/platform/platform.controller.ts (1)
239-242: Use the auth user interface instead of Prismauserfor request context.
@User()typically yields an auth-context object (e.g.,IUserRequestInterface), not a Prisma entity. Typing it asuserreduces type safety and can mislead about available fields.♻️ Suggested type alignment
- async createInvitation( - `@Body`() createEcosystemInvitationDto: CreateEcosystemInvitationDto, - `@User`() reqUser: user, + async createInvitation( + `@Body`() createEcosystemInvitationDto: CreateEcosystemInvitationDto, + `@User`() reqUser: IUserRequestInterface, `@Res`() res: Response ): Promise<Response> {- async getInvitations(`@User`() reqUser: user, `@Res`() res: Response): Promise<Response> { + async getInvitations(`@User`() reqUser: IUserRequestInterface, `@Res`() res: Response): Promise<Response> {Also applies to: 269-270
libs/prisma-service/prisma/schema.prisma (1)
706-717: Add an index onintents.ecosystemIdfor frequent lookups.Line 708 introduces
ecosystemId, and repository queries filter by this field. Add an index to avoid sequential scans as the table grows.♻️ Proposed Prisma schema change
model intents { id String `@id` `@default`(uuid()) `@db.Uuid` ecosystemId String `@db.Uuid` name String `@db.VarChar`(500) description String? createDateTime DateTime `@default`(now()) `@db.Timestamptz`(6) createdBy String `@db.Uuid` lastChangedDateTime DateTime `@default`(now()) `@db.Timestamptz`(6) lastChangedBy String `@db.Uuid` ecosystem ecosystem `@relation`(fields: [ecosystemId], references: [id]) intentTemplates intent_templates[] + + @@index([ecosystemId]) }
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
shitrerohit
approved these changes
Jan 22, 2026
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
|
sujitaw
approved these changes
Jan 27, 2026
pranalidhanavade
merged commit 7863c23
into
feat/platform_admin_and_ecosystem
5 checks passed
pranalidhanavade
added a commit
that referenced
this pull request
Jan 30, 2026
…1547) * feat: create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: create intent mapping and create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: move validations from ecosystem repository to ecosystem service Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
pranalidhanavade
added a commit
that referenced
this pull request
Jan 30, 2026
…1547) * feat: create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: create intent mapping and create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: move validations from ecosystem repository to ecosystem service Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
pranalidhanavade
added a commit
that referenced
this pull request
Jan 31, 2026
* feat: ecosystem service and create ecosystem invitation API route (#1540) * feat/add script to add platform admin keycloak and role Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/eslint issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/coderabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/changes to fetch value from db Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: ecosystem service and create ecosystem invitation API route Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: get all invitations api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: removed userId parameter from send invitation and get invitation api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: create and get ecosystem api routes Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warning Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings and suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings resolved Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolved comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Co-authored-by: sujitaw <sujit.sutar@ayanworks.com> * feat: Add script to add platform admin to keycloak and create user org roles (#1538) * feat/add script to add platform admin keycloak and role Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/eslint issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/coderabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/changes to fetch value from db Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: ecosystem member invitation and management API's (#1545) * feat/add script to add platform admin keycloak and role Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/eslint issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/coderabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: ecosystem service and create ecosystem invitation API route Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: get all invitations api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * wip Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * wip completed invite member and update status for invitation Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * wip Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * wip Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat/added ecosystem invitation workflow apis Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/code rabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/minor typo issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/ pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Co-authored-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix/version for nest-cli Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: add dockerfile for ecosystem Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com> * feat: add ecosystemt in github actions workflow Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com> * feat: create intent API endpoints and intent template mapping APIs (#1547) * feat: create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: create intent mapping and create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: move validations from ecosystem repository to ecosystem service Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: resloved issue for docker build (#1549) Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: Enable/disable ecosystem (#1550) * refactor: added isEcosystemEnabled flag in database in platform_config table Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: enable/disable ecosystem feature from database Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: enable/disable ecosystem feature and delete intent API issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * coderabbit comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix/code rabbit issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/code rabbit issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com> Co-authored-by: sujitaw <sujit.sutar@ayanworks.com> Co-authored-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>
shitrerohit
pushed a commit
that referenced
this pull request
Jan 31, 2026
* feat: ecosystem service and create ecosystem invitation API route (#1540) * feat/add script to add platform admin keycloak and role Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/eslint issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/coderabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/changes to fetch value from db Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: ecosystem service and create ecosystem invitation API route Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: get all invitations api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: removed userId parameter from send invitation and get invitation api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: create and get ecosystem api routes Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warning Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings and suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings resolved Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolved comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * resolve comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Co-authored-by: sujitaw <sujit.sutar@ayanworks.com> * feat: Add script to add platform admin to keycloak and create user org roles (#1538) * feat/add script to add platform admin keycloak and role Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/eslint issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/coderabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/changes to fetch value from db Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: ecosystem member invitation and management API's (#1545) * feat/add script to add platform admin keycloak and role Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/eslint issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/coderabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: ecosystem service and create ecosystem invitation API route Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit warnings Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: get all invitations api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * wip Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * wip completed invite member and update status for invitation Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * wip Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * wip Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat/added ecosystem invitation workflow apis Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/code rabbit comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/minor typo issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/ pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/pr comments Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Co-authored-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix/version for nest-cli Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * feat: add dockerfile for ecosystem Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com> * feat: add ecosystemt in github actions workflow Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com> * feat: create intent API endpoints and intent template mapping APIs (#1547) * feat: create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * feat: create intent mapping and create intent APIs Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: move validations from ecosystem repository to ecosystem service Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: resloved issue for docker build (#1549) Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: Enable/disable ecosystem (#1550) * refactor: added isEcosystemEnabled flag in database in platform_config table Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: enable/disable ecosystem feature from database Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix: coderabbit suggestions Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * refactor: enable/disable ecosystem feature and delete intent API issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * coderabbit comments on PR Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix/code rabbit issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> * fix/code rabbit issue Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> --------- Signed-off-by: sujitaw <sujit.sutar@ayanworks.com> Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com> Co-authored-by: sujitaw <sujit.sutar@ayanworks.com> Co-authored-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Summary by CodeRabbit
New Features
Refactor
Chores
✏️ Tip: You can customize this high-level summary in your review settings.