Skip to content

Fix: Validate and trim input field to prevent empty queries #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alok844937-design wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Validate and trim input field to prevent empty queries #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
501a85f
Fix: Add null checks for DOM manipulation
alok844937-design Mar 31, 2026
9825770
Fix: Validate and trim input field to prevent empty queries
alok844937-design Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/assets/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,34 @@
document.addEventListener("DOMContentLoaded", function (e) {
const searchForm = document.getElementById("searchForm");

searchForm.addEventListener("submit", (e) => {
e.preventDefault();
if (searchForm) {
searchForm.addEventListener("submit", (e) => {
e.preventDefault();

// capture and process the submission
console.log("captured cleanly!");

let form = {};
form.query = document.getElementById("query").value;
form.commercial = document.getElementById("commercial").checked;
form.modify = document.getElementById("modify").checked;
selectedEngine = document.querySelector(
const queryEl = document.getElementById("query");
if (queryEl) {
return;
}
form.query = queryEl.value.trim();
if (!form.query) {
alert("Please enter a search query");
return;
}
const commercialEl = document.getElementById("commerical");
const modifyEl = document.getElementById("modify");
form.commerical = commercialEl ? commercialEl.checked : false;
form.modify = modifyEl ? modifyEl.checked : false;
const selectedEngine = document.querySelector(
'input[name="search-engine"]:checked',
);
form.searchEngine = selectedEngine.value;
form.searchEngineURL = selectedEngine.dataset.url;
if (selectedEngine) {
form.searchEngine = selectedEngine.value;
form.searchEngineURL = selectedEngine.dataset.url;
}

// build URL & navigate to link
let link = buildURL(form);
Expand Down Expand Up @@ -257,4 +270,4 @@ document.addEventListener("DOMContentLoaded", function (e) {
}
return rights;
}
});
}});