Skip to content

Fix: Add null checks for DOM manipulation to prevent runtime errors#338

Open
alok844937-design wants to merge 1 commit intocreativecommons:mainfrom
alok844937-design:fix-font-url
Open

Fix: Add null checks for DOM manipulation to prevent runtime errors#338
alok844937-design wants to merge 1 commit intocreativecommons:mainfrom
alok844937-design:fix-font-url

Conversation

@alok844937-design
Copy link
Copy Markdown

Fixes

Description

This PR fixes a bug where DOM elements were accessed without null checks, which could lead to runtime errors when elements are not present in the DOM.

Technical details

  • Added null check for searchForm before attaching event listener
  • Added null check for selectedEngine before accessing its properties
  • Added null checks for query, commercial, and modify elements
  • Ensured safe DOM access to prevent runtime crashes

Tests

  • Ran the project locally using Live Server
  • Verified that the application works correctly
  • Checked browser console to ensure no runtime errors
  • Confirmed that the code does not crash when DOM elements are missing

Checklist

  • I have read and understood the Developer Certificate of Origin (DCO), below, which covers the contents of this pull request (PR).
  • My pull request doesn't include code or content generated with AI (also see Avoiding generative AI development tools — Creative Commons Open Source).
  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated unit tests and/or test scripts for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@alok844937-design alok844937-design requested a review from a team as a code owner March 31, 2026 20:19
@alok844937-design alok844937-design requested review from TimidRobot and possumbilities and removed request for a team March 31, 2026 20:19
@cc-open-source-bot cc-open-source-bot moved this to In review in possumbilities Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

[Bug] Add Null Checks for DOM Manipulation to Prevent Runtime Errors

2 participants