Skip to content

Conversation

@kylecarbs
Copy link
Contributor

This was broken by: nodejs/node@b970634

@kylecarbs
Copy link
Contributor Author

https://www.npmjs.com/package/@kylecarbs/http-parser-js is published if anyone would like to use the fix immediately!

@Jimbly
Copy link
Collaborator

Jimbly commented Jan 4, 2025

For some reason the tests have been sitting "queued" for a day and not running, and I'm not sure they'd even catch this, but... I'm guessing this change will break anyone using the library on any other version of Node, as you're now not passing parameters that are previously expected. Taking a quick look, I think just changing it to always pass buf.slice(start, end), 0, length as 3 parameters should work (always pass the sliced buffer, and always have a start+length of the entire buffer)?

@kylecarbs
Copy link
Contributor Author

@Jimbly will do in a bit!

@kylecarbs
Copy link
Contributor Author

@Jimbly fixed!

@Jimbly
Copy link
Collaborator

Jimbly commented Jan 9, 2025

Not sure why the automated tests aren't running, but I was able to manually run them (Node v16, Python 2.7) and all passed, so, looks good!

@Jimbly Jimbly merged commit 9e5daea into creationix:master Jan 9, 2025
0 of 6 checks passed
@Jimbly
Copy link
Collaborator

Jimbly commented Jan 9, 2025

Published to NPM as v0.5.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants