Trigger global search sync after static indexing#3546
Open
bbbtttiii wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for crds-jekyll ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crds-netstill indexes legacy static pages into the child Algolia static index (demo_crds_net_static/crds_net_static), but that work did not trigger a rebuild of the blended global search index afterward.That meant static-page updates could be present in the child index while still being stale or missing in
global_search_demo/global_search_prod.Solution
After static-page indexing completes in
crds-net, this change sends a follow-up request tosync-global-search-backgroundincrds-unifiedwith:slice=crds_net_staticapplySettings=falsedemoorprod)This keeps the existing static indexing behavior in place, but adds the missing handoff so the global search index can rebuild from the updated static slice.
Corresponding Branches
Related search rollout work also exists in:
crds-unifiedonprod/global-search-indexingcrds-unified-componentsonprod/global-search-modalTesting
Validate this change from the
crds-netdeploy/build logs.What to verify in the build log
Look for the static indexing hook output in this order:
Copied: ... -> _site_static/... for static page indexingCopying settings from 'crds_settings' to 'demo_crds_net_static'...Successfully copied settings from 'crds_settings' to 'demo_crds_net_static'Successfully indexed 11 records to Algolia index 'demo_crds_net_static'.[global-search-trigger] source=static env=demo status=...What has already been validated
A deploy preview built from commit
dc9a10bshowed:_site_staticcrds_settingstodemo_crds_net_staticdemo_crds_net_staticCurrent known gap
That same deploy log returned:
[global-search-trigger] source=static env=demo status=404This means:
sync-global-search-backgroundendpoint was not available on stable demo for that buildQA expectation for this PR
For this PR specifically, the important validation is:
crds-netstill successfully builds and indexes static recordsFollow-up validation after
crds-unifiedis live on demoOnce
sync-global-search-backgroundis available on stable demo, rerun acrds-netbuild and confirm:404to200or202About Us,What We Believe, orSeven Hillsexists indemo_crds_net_staticglobal_search_demo