Add Windows builders for libaom and brotli#1072
Merged
crazywhalecc merged 4 commits intocrazywhalecc:mainfrom Mar 23, 2026
Merged
Add Windows builders for libaom and brotli#1072crazywhalecc merged 4 commits intocrazywhalecc:mainfrom
crazywhalecc merged 4 commits intocrazywhalecc:mainfrom
Conversation
Both libraries are listed in lib.json and used as transitive dependencies (libaom via libavif, brotli via freetype/curl) but had no Windows builder, causing builds to fail with "library [X] is in the lib.json list but not supported to compile". libaom: Uses builddir instead of build to avoid collision with the source tree's build/cmake/ directory. Matches the Unix builder's AOM_TARGET_CPU=generic setting for portability. brotli: Standard CMake build with shared libs and tools disabled. Also adds static-libs-windows entry for libaom in lib.json.
crazywhalecc
approved these changes
Mar 23, 2026
Owner
|
These libs has been implemented on v3 version though, but no reason not to fix this on v2. Note that I have not conducted full testing; I have only tried building GD (I fixed the issues with FreeType), libaom, and Brotli on Windows. |
crazywhalecc
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing Windows CMake builders for
libaomandbrotli. Both are listed inlib.jsonand required as transitive dependencies when building with--with-suggested-libs, but had no Windows implementation.Changes
src/SPC/builder/windows/library/libaom.php— CMake builder usingbuilddir(notbuild) to avoid collision with libaom's source treebuild/cmake/directory. UsesAOM_TARGET_CPU=genericmatching the Unix builder.src/SPC/builder/windows/library/brotli.php— Standard CMake builder with shared libs and tools disabled.config/lib.json— Addedstatic-libs-windows: ["aom.lib"]for libaom.Context
Without these builders, all Windows builds that include
gdwith--with-suggested-libsfail immediately:(After fixing libaom,
brotlisurfaces with the same error.)Test plan
libavifshould findaom.libin the build rootfreetype/curlshould find brotli libs in the build root