Add Windows builder for libaom library#1071
Closed
hmennen90 wants to merge 1 commit intocrazywhalecc:mainfrom
Closed
Add Windows builder for libaom library#1071hmennen90 wants to merge 1 commit intocrazywhalecc:mainfrom
hmennen90 wants to merge 1 commit intocrazywhalecc:mainfrom
Conversation
libaom was listed in lib.json and used as a dependency of libavif, but had no Windows library builder, causing all Windows builds to fail with: "library [libaom] is in the lib.json list but not supported to compile" This adds the missing Windows CMake builder following the same pattern as other Windows library builders (libavif, libwebp, freetype). The builder disables docs, examples, tests, and tools for a minimal static build and uses AOM_TARGET_CPU=generic for portability, matching the Unix builder. Also adds the static-libs-windows entry to lib.json so the build system can locate the produced aom.lib artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libaom(src/SPC/builder/windows/library/libaom.php)static-libs-windowsentry tolib.jsonforaom.libProblem
libaomis listed inlib.jsonand required as a dependency oflibavif, but has no Windows library builder. This causes all Windows builds that includegd(with libavif support) to fail with:This also affects the CI test workflow — all three Windows jobs (PHP 8.1, 8.4, 8.5) currently fail due to this.
Implementation
The builder follows the same CMake pattern as other Windows library builders (
libavif,libwebp,freetype):FileSystem::resetDir()for clean build directoryBUILD_ROOT_PATHinstall prefix-DAOM_TARGET_CPU=genericfor portability (matching the Unix builder)Test plan
libavifWindows build should findaom.libin the build root