Made proxy work for multiple maps in Shiny#225
Open
hckiang wants to merge 9 commits intocrazycapivara:masterfrom
Open
Made proxy work for multiple maps in Shiny#225hckiang wants to merge 9 commits intocrazycapivara:masterfrom
hckiang wants to merge 9 commits intocrazycapivara:masterfrom
Conversation
I have no idea how it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes this issue:
#224
Apparently Shiny's addCustomMessageHandler is a misnomer: it should be called
setCustomMessageHandlerbecause each time you add a handler to the same keyword it'll replace the previous one. This fix just gives handlers of each deckgl widget a unique name so that they can coexist.