-
Notifications
You must be signed in to change notification settings - Fork 4
Tests: Fix testcontainers. CI: Use uv across the board.
#686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,13 +6,17 @@ on: | |
| paths: | ||
| - '.github/workflows/kinesis.yml' | ||
| - 'cratedb_toolkit/io/kinesis/**' | ||
| - 'cratedb_toolkit/testing/testcontainers/localstack.py' | ||
| - 'cratedb_toolkit/testing/testcontainers/util.py' | ||
| - 'tests/io/kinesis/**' | ||
| - 'pyproject.toml' | ||
| push: | ||
| branches: [ main ] | ||
| paths: | ||
| - '.github/workflows/kinesis.yml' | ||
| - 'cratedb_toolkit/io/kinesis/**' | ||
| - 'cratedb_toolkit/testing/testcontainers/localstack.py' | ||
| - 'cratedb_toolkit/testing/testcontainers/util.py' | ||
| - 'tests/io/kinesis/**' | ||
| - 'pyproject.toml' | ||
|
|
||
|
|
@@ -39,13 +43,14 @@ jobs: | |
| os: ["ubuntu-latest"] | ||
| python-version: [ | ||
| "3.10", | ||
| "3.13", | ||
| # TODO: Integration tests became flaky again. Let's investigate later. | ||
| # kinesis.exceptions.StreamDoesNotExist: Stream 'testdrive' does not exist | ||
| # "3.13", | ||
|
Comment on lines
-42
to
+48
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We reported this or a related problem already. Apparently, it is coming back, now on Python 3.13? We think it is most probably related to our integration test setup and related timing changes by cleaning up the testcontainers rig recently. As the comment says: Let's investigate later. /cc @hampsterx |
||
| ] | ||
|
|
||
| env: | ||
| OS: ${{ matrix.os }} | ||
| PYTHON: ${{ matrix.python-version }} | ||
| UV_SYSTEM_PYTHON: true | ||
| # Do not tear down Testcontainers | ||
| TC_KEEPALIVE: true | ||
|
|
||
|
|
@@ -65,19 +70,13 @@ jobs: | |
| - name: Acquire sources | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Install Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| cache-dependency-glob: | | ||
| pyproject.toml | ||
| activate-environment: 'true' | ||
| cache-suffix: ${{ matrix.python-version }} | ||
| enable-cache: true | ||
| version: "latest" | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Set up project | ||
| run: | | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.