Merged
Conversation
feaf4dd to
6f2e5a3
Compare
Collaborator
|
FYI we prefer that your commits reflect how they should be reviewed and merged and not how they were developed, including being atomic. |
fix: Add install step for linux arm build
6f2e5a3 to
d51023b
Compare
Contributor
Author
|
@epage I've squashed the commits |
Collaborator
|
Thanks! |
Contributor
Author
|
@epage Looks like the build succeeded but the release didn't get published - i think the macOS build timed out or something - are you able to re-run it? |
Collaborator
|
Re-ran it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I need to run this on a devpod with docker on a ARM64 machine and it would be great to have a pre-build binary.
Thank you for considering!
(testing this is kinda difficult - I can't create releases on my fork - so I haven't fully confirmed this works, but I've done this before and it feels correct - would appreciate the help)