Skip to content

[CI] Use 7-char short sha in --version to match Docker tag #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slashmo merged 1 commit into from
Jun 6, 2026
Merged

[CI] Use 7-char short sha in --version to match Docker tag #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4

# Match docker/metadata-action's default `type=sha` format (7-char short sha) so the
# baked-in version aligns with the public-facing per-commit image tag.
- name: Compute version
id: version
run: echo "value=sha-${GITHUB_SHA::7}" >> "$GITHUB_OUTPUT"

- name: Build and push
uses: docker/build-push-action@v7
with:
Expand All @@ -57,7 +63,7 @@ jobs:
push: true
tags: ghcr.io/${{ github.repository }}:sha-${{ github.sha }}${{ matrix.variant.tag_suffix }}-${{ matrix.arch.name }}
build-args: |
CRANECTL_VERSION=sha-${{ github.sha }}
CRANECTL_VERSION=${{ steps.version.outputs.value }}
cache-from: type=gha,scope=${{ matrix.variant.name }}-${{ matrix.arch.name }}
cache-to: type=gha,mode=max,scope=${{ matrix.variant.name }}-${{ matrix.arch.name }}

Expand Down
Loading