fix: handle null formatting in date parsing#1656
Open
aedan-umd wants to merge 1 commit intocraftcms:6.xfrom
Open
fix: handle null formatting in date parsing#1656aedan-umd wants to merge 1 commit intocraftcms:6.xfrom
aedan-umd wants to merge 1 commit intocraftcms:6.xfrom
Conversation
- Default to 'auto' formatting when parameter is null - Prevents TypeError in DateHelper::parseString()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1655
When calling
craft\feedme\services\Process->processFeed()from CLI using JSON data exported by Craft's export button, the$formattingparameter can be null when not specified in$fieldInfo. This causes a TypeError inDateHelper::parseString().Changes
parseDateAttribute()to default to 'auto' formattingTesting