Skip to content

change the default link type #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonkelly merged 3 commits into from
Mar 30, 2026
+10 −2
Merged

change the default link type #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cedc82e
change the preselected link type to the first option (entry in most c…
i-just Mar 25, 2026
8e19046
Merge branch '5.x' into feature/533-change-default-link-type
brandonkelly Mar 30, 2026
a5cfee2
Release note
brandonkelly Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- New links now default to the first available link type option (usually “Entry”). ([#550](https://github.com/craftcms/ckeditor/pull/550))
- Fixed a bug where invisible characters were being stripped out of field contents. ([#537](https://github.com/craftcms/ckeditor/issues/537))
- Fixed a bug where Link modals had empty Site menus when no element was selected. ([#534](https://github.com/craftcms/ckeditor/discussions/534), [#545](https://github.com/craftcms/ckeditor/issues/545))

Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/ckeditor/dist/ckeditor5-craftcms.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion src/web/assets/ckeditor/src/link/linkui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,14 @@ export default class CraftLinkUI extends Plugin {
this.linkTypeDropdownItemModels[elementRefHandle].linkOption,
);
} else {
this._showLinkTypeForm('default');
// if we don't have elementRefHandle and the input value is actually empty
// default to showing the first option from the linkOptions menu (e.g. Entry)
if (this._urlInputValue().length == 0) {
this._selectLinkTypeDropdownItem(this.linkOptions[0].refHandle);
this._showLinkTypeForm(this.linkOptions[0]);
} else {
this._showLinkTypeForm('default');
}
}
});

Expand Down
Loading