Skip to content

Comments

adds unit comparison tests#78

Open
raleigh-g-thompson wants to merge 1 commit intomainfrom
feature/add-datetime-unit-comparison-tests
Open

adds unit comparison tests#78
raleigh-g-thompson wants to merge 1 commit intomainfrom
feature/add-datetime-unit-comparison-tests

Conversation

@raleigh-g-thompson
Copy link
Contributor

fixes #51

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I learned some things that I hadn't realized the spec says. Thanks!

@brynrhodes - I think there are a few opportunities for clarification around these topics in the spec. I've filed Jira issues for them:

FHIR-53172: Comparisons Between Calendar and Definite Duration Quantities may affect this PR, as the spec is not clear about how "not comparable" should be implemented.

FHIR-53173: Comparison of Durations with Months, Days, and Years shouldn't affect this PR because I think the spec is clear enough in some parts, but it still needs clarification for consistency in other parts.

I am approving this PR because I suspect its interpretation of "not comparable" as resulting in null is likely correct, but I'd suggest we get confirmation from @brynrhodes before merging.

@alexzautke
Copy link

@brynrhodes I'm currently fixing related issues in the .NET engine. Could you comment on the current status of these tests?

@alexzautke
Copy link

@brynrhodes Do we also have related tests for date arithmetic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for date/time unit comparisons

4 participants