Add arithmetic function tests#42
Conversation
brynrhodes
left a comment
There was a problem hiding this comment.
I don't think we have the boundary tests sorted, there is an active thread in FHIRPath about that. Can I ask that the boundary tests be taken out of this PR and put in a separate PR?
|
Done, this PR no longer includes the new tests for |
|
How should we handle the cases where the server doesn't handle a set of functions? In this case we are testing for Long values and FHIR R4 doesn't support those. Should we have some feature in the test-runner that selective applies tests by FHIR version? |
|
Fair point, Tests, Group, and Test structures all have a However, CQL 1.5 does support Long even if FHIR R4 does not, so the test is valid for CQL 1.5, and we allow for this in R4 by returning/passing the value as a string: https://build.fhir.org/ig/HL7/cql-ig/conformance.html#conformance-requirement-4-3 |
This PR adds new conformance tests for arithmetic functions. I picked all the ones from https://github.com/cqframework/clinical_quality_language/blob/7e91478/Src/java/engine/src/test/resources/org/opencds/cqf/cql/engine/execution/CqlArithmeticFunctionsTest.cql which didn't exist yet here.
Using CVL (literals only) for the expected output values.
This is independent from #33.