Add NPM package loader classes as a first step to introducing wider NPM functionality#724
Add NPM package loader classes as a first step to introducing wider NPM functionality#724lukedegruchy wants to merge 10 commits intomasterfrom
Conversation
…and scenarios still need to be tweaked.
|
Formatting check succeeded! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
============================================
- Coverage 73.31% 72.98% -0.33%
Complexity 211 211
============================================
Files 487 495 +8
Lines 22979 23383 +404
Branches 2963 3003 +40
============================================
+ Hits 16846 17067 +221
- Misses 4675 4831 +156
- Partials 1458 1485 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukedegruchy
changed the title
|
There was a problem hiding this comment.
The changes in this file seem like formatting changes? Do we really need to make these changes as part of this PR?
|
|
||
| /** | ||
| * This interface exposes common functionality across all FHIR Questionnaire versions. | ||
| */ |
| .map(r -> (IKnowledgeArtifactAdapter) IAdapterFactory.forFhirVersion(r.getStructureFhirVersionEnum()) | ||
| .createResource(r)) | ||
| .sorted((a, b) -> versionComparator.compare(a.getVersion(), b.getVersion())) | ||
| .sorted((a, b) -> Versions.compareVersions(a.getVersion(), b.getVersion())) |
There was a problem hiding this comment.
Similar question, is this change needed by this PR?
There was a problem hiding this comment.
Should we have a PR that is just for the Measure adapter?
There was a problem hiding this comment.
I thought we talked about removing this? I don't understand why I would need to know where a Measure was loaded from?
| * <p/> | ||
| * Helps implement a migration from the old world of FHIR/Repository based resources for Libraries, | ||
| * Measures and eventually other clinical intelligence resources (such as PlanDefinitions or | ||
| * ValueSets), and the new world where they're derived from NPM packages. |
There was a problem hiding this comment.
I think we need to get on the same page here, I don't think it's right to characterize this as an "old world" and a "new world", they are different ways of getting at the resources, and one isn't replacing the other.
2 participants
Uh oh!
There was an error while loading. Please reload this page.