fix: prevent duplicate parameter resolution for %subject, %encounter and %practitioner in InputParameterResolver#1037
Open
not-mksv wants to merge 1 commit into
Conversation
… and %practitioner in InputParameterResolver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When a PlanDefinition is
$apply-ed, input parameters referenced in ActivityDefinitiondynamicValueexpressions are resolved twice - once at the PlanDefinition level and again at the ActivityDefinition level. This produces duplicate parameter values, which causes expressions like%encounter.period.startto fail silently.Root cause
InputParameterResolverreads the input resource from the server and stores it (e.g. as%encounter).toActivityRequest()inProcessDefinition.javapasses the already-resolved parameters to the ActivityDefinition'sApplyRequest.InputParameterResolvercopies the existing params and fetches the resource again, creating a duplicate entry for the same parameter.Fix
Guard the
%subject/%encounter/%practitionerblocks inInputParameterResolver.resolveParametersso the resolver only fetches when the parameter isn't already present in the passed-inbaseParameters.Test
Added testResolveParametersSkipsRefetchWhenAlreadyInBaseParametersR4 in InputParametersTest. It seeds baseParameters with all three keys plus matching IDs, then asserts the result has exactly 3 parameters and no duplicates.