Skip to content

Conversation

@alandefreitas
Copy link
Collaborator

@alandefreitas alandefreitas commented Dec 6, 2025

Fixes #881, moves us closer on #1113.

  • Swapped Duktape for JerryScript across CMake, CI, presets, bootstrap recipe, and the install
    docs; added a small port layer so it all hooks up cleanly.
  • Tightened the JS helper runtime: shared context lifetime, safer value accessors, clearer errors,
    and helper registration that keeps options/hash intact for block helpers; added unit tests to cover
    the new paths.
  • Added an addons-supplemental config option so you can layer extra addons/overrides; documented it and
    dropped in golden fixtures for the JS helpers. Also cleaned up the TestRunner include path.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

🚧 Danger.js checks for MrDocs are experimental; expect some rough edges while we tune the rules.

⚠️ Warnings

Warning

Commit 4289920 (feat: javascript helpers extension) changes 2962 source lines. Consider splitting it into smaller, reviewable chunks.

Warning

PR description looks empty. Please add a short rationale and testing notes.

✨ Highlights

  • 🧪 Existing golden tests changed (behavior likely shifted)

🧾 Changes by Scope

Scope Lines Δ Lines + Lines - Files Δ Files + Files ~ Files ↔ Files -
Source 2971 1034 1937 -5 - 6 - 11
Golden Tests 496 496 - 41 22 - 19 -
Tests 452 341 111 3 1 2 - -
Third-party 369 229 140 1 4 - - 3
CI / Roadmap 192 151 41 9 1 8 - -
Docs 113 34 79 3 - 3 - -
Other 24 2 22 - - 1 - 1
Build / Toolchain 21 7 14 2 - 2 - -
Total 4638 2294 2344 54 28 22 19 15

Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)

🔝 Top Files

  • src/lib/Support/JavaScript.cpp (Source): 2471 lines Δ (+750 / -1721)
  • src/test/Support/JavaScript.cpp (Tests): 387 lines Δ (+277 / -110)
  • src/lib/Gen/hbs/Builder.cpp (Source): 255 lines Δ (+164 / -91)

Generated by 🚫 dangerJS against 426e10d

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 6, 2025

An automated preview of the documentation is available at https://1126.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-12-07 20:41:46 UTC

@alandefreitas alandefreitas force-pushed the develop branch 3 times, most recently from f689c23 to e9faceb Compare December 7, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explore Javascript Engines

2 participants